From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: Docstring for define-key Date: Wed, 19 Feb 2003 15:18:03 -0700 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <3E54029B.4090903@ihs.com> References: <84adgsjkq0.fsf@lucy.is.informatik.uni-duisburg.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1045693216 11423 80.91.224.249 (19 Feb 2003 22:20:16 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 19 Feb 2003 22:20:16 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18lcZX-0002xr-00 for ; Wed, 19 Feb 2003 23:20:11 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18lcml-0008Os-00 for ; Wed, 19 Feb 2003 23:33:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18lcYC-0007h7-03 for emacs-devel@quimby.gnus.org; Wed, 19 Feb 2003 17:18:48 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18lcXu-0007gG-00 for emacs-devel@gnu.org; Wed, 19 Feb 2003 17:18:30 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18lcXn-0007fS-00 for emacs-devel@gnu.org; Wed, 19 Feb 2003 17:18:29 -0500 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18lcXm-0007fO-00 for emacs-devel@gnu.org; Wed, 19 Feb 2003 17:18:22 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18lcXi-0002qc-00 for ; Wed, 19 Feb 2003 23:18:18 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18lcXJ-0002oO-00 for ; Wed, 19 Feb 2003 23:17:53 +0100 Original-Lines: 21 Original-X-Complaints-To: usenet@main.gmane.org User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:0.9.4.1) Gecko/20020406 Netscape6/6.2.2 X-Accept-Language: en-us X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:11780 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11780 Kai Großjohann wrote: > When reading this, one could think that executing the same define-key > statement multiple times makes the KEYMAP grow. However, this is not > the case. Glancing at the code, I see that it seems to alter the old > binding, if one is already present. So one possibility to change it > is like this: > > If KEYMAP is a sparse keymap with a binding for KEY, the existing > binding is altered. If there is no binding for KEY, the new pair > binding KEY to DEF is added at the front of KEYMAP. > > The wording is not very good, I think. I think it's fine. My only suggestion is to replace "altered" with "modified" or "destructively modified". -- Kevin Rodgers