From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Joe Buehler Newsgroups: gmane.emacs.devel Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 5 Date: Fri, 03 Jan 2003 11:19:15 -0500 Organization: Spirent Communications Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <3E15B803.8080507@hekimian.com> References: Reply-To: joseph.buehler@spirentcom.com NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1041610945 25963 80.91.224.249 (3 Jan 2003 16:22:25 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 3 Jan 2003 16:22:25 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18UUaV-0006kb-00 for ; Fri, 03 Jan 2003 17:22:23 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18UUdC-00021r-00 for ; Fri, 03 Jan 2003 17:25:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18UUZg-0006nD-05 for emacs-devel@quimby.gnus.org; Fri, 03 Jan 2003 11:21:32 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18UUYG-0006bk-00 for emacs-devel@gnu.org; Fri, 03 Jan 2003 11:20:04 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18UUXw-0006Pj-00 for emacs-devel@gnu.org; Fri, 03 Jan 2003 11:19:47 -0500 Original-Received: from [64.47.34.2] (helo=python.hekimian.com) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18UUXV-0005zS-00 for emacs-devel@gnu.org; Fri, 03 Jan 2003 11:19:17 -0500 Original-Received: from hekimian.com (jbuehler-lt.hekimian.com [10.32.6.132]) by Service Version 5.5.2653.13) id ZW2HCWCJ; Fri, 3 Jan 2003 11:17:59 -0500 X-Sybari-Trust: c4021b44 f6624f78 c4b24ea6 00000109 User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: en-us, en Original-To: Eli Zaretskii In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10435 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10435 Eli Zaretskii wrote: >>+#ifdef _P >>+#undef _P >>+#endif >> #ifndef _P >> # ifdef __STDC__ >> # define _P(a) a > Why isn't the original #ifndef guard enough to solve the problem on > Cygwin? Could you please show how does the original code fail, and > explain why? The problem is that _P is defined in the cygwin header files in a manner that is incompatible with its usage above. It is one of a set of macros used in code that classifies characters as white space, printable, etc.: ctype.h:#define _P 020 ctype.h:#define ispunct(c) ((_ctype_+1)[(unsigned)(c)]&_P) ctype.h:#define isprint(c) ((_ctype_+1)[(unsigned)(c)]&(_P|_U|_L|_N|_B)) ctype.h:#define isgraph(c) ((_ctype_+1)[(unsigned)(c)]&(_P|_U|_L|_N)) The above usage in pop.c does not seem correct to me -- aren't symbols beginning with _ supposed to be reserved for the compilation system, to avoid conflicts such as this one? >>--- src/mem-limits.h 19 Aug 2002 17:45:50 -0000 1.31 >>+++ src/mem-limits.h 6 Dec 2002 16:35:33 -0000 >>@@ -46,6 +46,10 @@ >> #define BSD4_2 >> #endif >> >>+#ifdef CYGWIN >>+#define BSD4_2 >>+#endif > > > Can't this be done in src/s/cygwin.h? Setgid on a directory does not cause group inheritance under cygwin, so the code in dired.c for BSD4_2 is incorrect in that case. The ifdef could be moved to dired.c. I don't like the idea of defining it in cygwin.h, however, since BSD4_2 has nothing to do with cygwin... -- Joe Buehler