From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Paul Wallington Newsgroups: gmane.emacs.devel Subject: Re: Some vc-dispatcher nitpicks Date: Fri, 16 May 2008 22:11:26 +0100 Message-ID: <3D93D0E7-511D-4D93-81DC-4CD3B5658395@pobox.com> References: <20080516195554.GA23205@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1210972367 20836 80.91.229.12 (16 May 2008 21:12:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 May 2008 21:12:47 +0000 (UTC) Cc: Glenn Morris , emacs-devel@gnu.org, esr@snark.thyrsus.com To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 16 23:13:22 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jx7Ei-0004KE-AV for ged-emacs-devel@m.gmane.org; Fri, 16 May 2008 23:13:08 +0200 Original-Received: from localhost ([127.0.0.1]:49013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jx7Dy-00083c-OR for ged-emacs-devel@m.gmane.org; Fri, 16 May 2008 17:12:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jx7Dt-00082Y-2R for emacs-devel@gnu.org; Fri, 16 May 2008 17:12:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jx7Dq-00081O-Hc for emacs-devel@gnu.org; Fri, 16 May 2008 17:12:16 -0400 Original-Received: from [199.232.76.173] (port=52010 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jx7Dq-00081H-7N for emacs-devel@gnu.org; Fri, 16 May 2008 17:12:14 -0400 Original-Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:55599 helo=sasl.smtp.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jx7Dg-00075q-VY; Fri, 16 May 2008 17:12:05 -0400 Original-Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id D499F5B71; Fri, 16 May 2008 17:11:49 -0400 (EDT) Original-Received: from mini.home (host86-146-4-91.range86-146.btcentralplus.com [86.146.4.91]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 489B65B6F; Fri, 16 May 2008 17:11:40 -0400 (EDT) In-Reply-To: <20080516195554.GA23205@thyrsus.com> X-Mailer: Apple Mail (2.919.2) X-Pobox-Relay-ID: B31FCA2E-238C-11DD-8485-80001473D85F-02562057!a-sasl-fastnet.pobox.com X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97292 Archived-At: On 16 May 2008, at 20:55, Eric S. Raymond wrote: > Glenn Morris : >> In toplevel form: >> vc-dispatcher.el:768:1:Warning: !! The file uses old-style >> backquotes !! >> This functionality has been obsolete for more than 10 years already >> and will be removed soon. See (elisp)Backquote in the manual. > > I think this may be a false positive. I did look into it; it seems > the line > construct triggering the warning is the prefix comma on line 804, > which looks > like new-style to me. Correct me if I'm wrong. Yup. But there's no actual backquote for it to apply to though. >> In vc-at-event: >> vc-dispatcher.el:812:16:Warning: Function `gensym' from cl package >> called at runtime > > Yeah, that's a real warning that I inherited. Not sure why it's a > problem, though. `gensym' is a function rather than a macro and it apparently doesn't have a corresponding compiler macro. Use or loading of cl at runtime by packages that are installed in the Emacs sources is verboten. Is it okay to install the following patch? 2008-05-16 John Paul Wallington * vc-dispatcher.el (vc-dir-mode-map): Fix backquote. (vc-at-event): Use `make-symbol' instead of `gensym'. --- vc-dispatcher.el.~1.48.~ 2008-05-15 18:00:35.000000000 +0100 +++ vc-dispatcher.el 2008-05-16 21:52:45.000000000 +0100 @@ -798,7 +798,7 @@ ;; Hook up the menu. (define-key map [menu-bar vc-dir-mode] - '(menu-item + `(menu-item ;; This is used so that client modes can add mode-specific ;; menu items to vc-dir-menu-map. "*vc-dispatcher*" ,vc-dir-menu-map :filter vc-dir-menu-map- filter)) @@ -809,7 +809,7 @@ "Evaluate `body' wich point located at event-start of `event'. If `body' uses `event', it should be a variable, otherwise it will be evaluated twice." - (let ((posn (gensym "vc-at-event-posn"))) + (let ((posn (make-symbol "vc-at-event-posn"))) `(let ((,posn (event-start ,event))) (save-excursion (set-buffer (window-buffer (posn-window ,posn)))