From: John Paul Wallington <jpw@pobox.com>
To: esr@thyrsus.com
Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org, esr@snark.thyrsus.com
Subject: Re: Some vc-dispatcher nitpicks
Date: Fri, 16 May 2008 22:11:26 +0100 [thread overview]
Message-ID: <3D93D0E7-511D-4D93-81DC-4CD3B5658395@pobox.com> (raw)
In-Reply-To: <20080516195554.GA23205@thyrsus.com>
On 16 May 2008, at 20:55, Eric S. Raymond wrote:
> Glenn Morris <rgm@gnu.org>:
>> In toplevel form:
>> vc-dispatcher.el:768:1:Warning: !! The file uses old-style
>> backquotes !!
>> This functionality has been obsolete for more than 10 years already
>> and will be removed soon. See (elisp)Backquote in the manual.
>
> I think this may be a false positive. I did look into it; it seems
> the line
> construct triggering the warning is the prefix comma on line 804,
> which looks
> like new-style to me. Correct me if I'm wrong.
Yup. But there's no actual backquote for it to apply to though.
>> In vc-at-event:
>> vc-dispatcher.el:812:16:Warning: Function `gensym' from cl package
>> called at runtime
>
> Yeah, that's a real warning that I inherited. Not sure why it's a
> problem, though.
`gensym' is a function rather than a macro and it apparently doesn't
have a corresponding compiler macro. Use or loading of cl at runtime
by packages that are installed in the Emacs sources is verboten.
Is it okay to install the following patch?
2008-05-16 John Paul Wallington <jpw@pobox.com>
* vc-dispatcher.el (vc-dir-mode-map): Fix backquote.
(vc-at-event): Use `make-symbol' instead of `gensym'.
--- vc-dispatcher.el.~1.48.~ 2008-05-15 18:00:35.000000000 +0100
+++ vc-dispatcher.el 2008-05-16 21:52:45.000000000 +0100
@@ -798,7 +798,7 @@
;; Hook up the menu.
(define-key map [menu-bar vc-dir-mode]
- '(menu-item
+ `(menu-item
;; This is used so that client modes can add mode-specific
;; menu items to vc-dir-menu-map.
"*vc-dispatcher*" ,vc-dir-menu-map :filter vc-dir-menu-map-
filter))
@@ -809,7 +809,7 @@
"Evaluate `body' wich point located at event-start of `event'.
If `body' uses `event', it should be a variable,
otherwise it will be evaluated twice."
- (let ((posn (gensym "vc-at-event-posn")))
+ (let ((posn (make-symbol "vc-at-event-posn")))
`(let ((,posn (event-start ,event)))
(save-excursion
(set-buffer (window-buffer (posn-window ,posn)))
next prev parent reply other threads:[~2008-05-16 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 18:25 Some vc-dispatcher nitpicks Glenn Morris
2008-05-16 19:55 ` Eric S. Raymond
2008-05-16 21:11 ` John Paul Wallington [this message]
2008-05-16 22:08 ` Eric S. Raymond
2008-05-17 10:42 ` John Paul Wallington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D93D0E7-511D-4D93-81DC-4CD3B5658395@pobox.com \
--to=jpw@pobox.com \
--cc=emacs-devel@gnu.org \
--cc=esr@snark.thyrsus.com \
--cc=esr@thyrsus.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).