From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration in python.el Date: Sat, 15 Oct 2022 16:15:36 -0700 Message-ID: <3D4626C7-6D60-4051-B22C-1811891B1BDF@gmail.com> References: <3A68545C-2E40-4BB4-8563-8041A5452634@gmail.com> <87y1twlr0v.fsf@gmail.com> <83czb8ycpo.fsf@gnu.org> <87tu4klfcw.fsf@gmail.com> <87ill0le20.fsf@gmail.com> <87y1ttfmj8.fsf@gmail.com> <19950F30-F4DB-4CE4-9257-24DA39594669@gmail.com> <87czb47jya.fsf@gmail.com> <87wn9c7xxd.fsf@gmail.com> <83wn9altdu.fsf@gnu.org> <8182363C-3BB3-4741-B916-09C78971CE30@gmail.com> <6AAE43C1-DBE9-448C-9C76-9D2188EF5A91@gmail.com> <834jw8b73n.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9332"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Augusto Stoffel , Matthias Meulien , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 16 01:18:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojqPx-0002Fm-Eu for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Oct 2022 01:18:09 +0200 Original-Received: from localhost ([::1]:58284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojqPw-00045x-AT for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Oct 2022 19:18:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojqNa-0002w7-4E for emacs-devel@gnu.org; Sat, 15 Oct 2022 19:15:43 -0400 Original-Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:37748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojqNY-0000K1-Ai; Sat, 15 Oct 2022 19:15:41 -0400 Original-Received: by mail-pj1-x102f.google.com with SMTP id p3-20020a17090a284300b0020a85fa3ffcso11115489pjf.2; Sat, 15 Oct 2022 16:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CGNfnM3H5dJTWJDB7Q9hPNmz42Ov6RVKsuox7AE8czk=; b=S84k7MAw7vHuXE0VKhzFN4wkhGZcopuievYhI3zAKIP66/hcKlMGRnFTpthTXSjzjq MV5E8yTaYPjYuTsd9F+7ASyLxR9Rc7BnvpaR5a+8MVCUo3rNGe7KrvEBNk9jmTTrfEhc yR6DCtvSZbg6qDwuLfDqu3lDX6tQ7u+kPyFw2Jev1edPcs7+HIrVWTc3O/dd2ns2BDzG lqinJR/b54662of3F41CZ97MpvJqGxe8m/cNcb+Szkwn79FgeadV4bTaGwmwD/wSSO6g kDu/Vnke4+Nn+bpKuDeDrkDX9P0y2kbwVqd1dIab4AEcbj0t5oNk7xvXb7uJNLSHZKGW tOSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CGNfnM3H5dJTWJDB7Q9hPNmz42Ov6RVKsuox7AE8czk=; b=xvdEJQFo7jBPaS2teBI4GA3ISXSyQ7ajI/f+cS07lF2aKcKiChPG4JKPJtRfQ7r/3P ZQv9xYNkKcWTHh25d7Zb25X78+S/006A1IOvotRQPGZBXreink/XVmhFA8VwKEkpNtNR w4YzHs/OYttpRhO+esfbWWeTG0+ekMzTOaXrLYIiNiLthaP2q0v2u8VAT9uqJWFO7B/D f3ICFlbjs0tR597W6OuTVRNK/5Ezln4HbUt5OPdJNKi9HP6wvBzr84XfHvyer51/uNeM xYwXNQZvg4UJbvG3Y5SR5n5nSN9/S2o0hP9qdU1QXosEqaV+P5LZZiGjJEsusW2/pWHo 3BYA== X-Gm-Message-State: ACrzQf2sHX0cyy9mBz6PW93fN+X3X0CwrlTldXC/xgkQZQdAvLmgzSaG v0LZSi1U0HsEp1INmVeSG4ZLJSeMRhw= X-Google-Smtp-Source: AMsMyM5rzyfnTKnZCLFkIF1plSBcI/6WOspftkbTh86O1U3BlDbUMHtMcsILaujw54H5pt0SHj5FWg== X-Received: by 2002:a17:902:720a:b0:181:150c:fcc4 with SMTP id ba10-20020a170902720a00b00181150cfcc4mr4859051plb.109.1665875737791; Sat, 15 Oct 2022 16:15:37 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id q13-20020a170902f34d00b0017680faa1a8sm3846087ple.112.2022.10.15.16.15.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Oct 2022 16:15:37 -0700 (PDT) In-Reply-To: <834jw8b73n.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=casouri@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297820 Archived-At: > On Oct 12, 2022, at 10:55 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Wed, 12 Oct 2022 16:43:30 -0700 >> Cc: Eli Zaretskii , >> Augusto Stoffel , >> Matthias Meulien , >> emacs-devel@gnu.org >>=20 >> What are some suggestions for kind names? We could provide the common = ones in the doctoring so major modes use the same names for them. I can = think of: function, type, keyword, constant, builtin, = string-interpolation, escape, assignment-lhs, macro, preprocessor, = string, comment, hmmm=E2=80=A6 this list is extremely similar to = font-lock-faces=E2=80=A6 >=20 > Exactly. So how about just taking the list from the font-lock-faces? > We can always add some more later, if we find it necessary. I have implemented this, but renamed :kind to :feature. See = treesit-font-lock-rules and treesit-font-lock-feature-list. Yuan=