Re: info,bookmark and bzip2

Re: info,bookmark and bzip2

[Richard Stallman]

Does this patch make it work?

*** bookmark.el.~1.59.~	Fri Dec 21 04:05:59 2001
--- bookmark.el	Thu Jun  6 18:41:39 2002
***************
*** 1078,1086 ****
--- 1078,1088 ----
     ((file-exists-p file)                       file)
     ((file-exists-p (concat file ".Z"))         (concat file ".Z"))
     ((file-exists-p (concat file ".gz"))        (concat file ".gz"))
+    ((file-exists-p (concat file ".bz2"))       (concat file ".bz2"))
     ((file-exists-p (concat file ".z"))         (concat file ".z"))
     ((file-exists-p (concat file ".info"))      (concat file ".info"))
     ((file-exists-p (concat file ".info.gz"))   (concat file ".info.gz"))
+    ((file-exists-p (concat file ".info.bz2"))  (concat file ".info.bz2"))
     ((file-exists-p (concat file ".info.Z"))    (concat file ".info.Z"))
     ((file-exists-p (concat file ".info.z"))    (concat file ".info.z"))
     ((vc-backend file)                          file) ; maybe VC has it?

Re: info,bookmark and bzip2

[Stefan Monnier]

> Does this patch make it work?
> 
> *** bookmark.el.~1.59.~	Fri Dec 21 04:05:59 2001
> --- bookmark.el	Thu Jun  6 18:41:39 2002
> ***************
> *** 1078,1086 ****
> --- 1078,1088 ----
>      ((file-exists-p file)                       file)
>      ((file-exists-p (concat file ".Z"))         (concat file ".Z"))
>      ((file-exists-p (concat file ".gz"))        (concat file ".gz"))
> +    ((file-exists-p (concat file ".bz2"))       (concat file ".bz2"))
>      ((file-exists-p (concat file ".z"))         (concat file ".z"))
>      ((file-exists-p (concat file ".info"))      (concat file ".info"))
>      ((file-exists-p (concat file ".info.gz"))   (concat file ".info.gz"))
> +    ((file-exists-p (concat file ".info.bz2"))  (concat file ".info.bz2"))
>      ((file-exists-p (concat file ".info.Z"))    (concat file ".info.Z"))
>      ((file-exists-p (concat file ".info.z"))    (concat file ".info.z"))
>      ((vc-backend file)                          file) ; maybe VC has it?

Yuck!  Can someone fix this code to use Info-suffix-list ?


	Stefan

Re: info,bookmark and bzip2

[Karl Fogel]

Stefan Monnier writes:
> Yuck!  Can someone fix this code to use Info-suffix-list ?

Yes, I will do that tonight.  Thanks for the suggestion!

-Karl

Re: info,bookmark and bzip2

[Robert Thorpe]

On 7 Jun 2002, at 19:49, Karl Fogel wrote:

> Okay, Robert, I applied a fix to bookmark.el.  Please let me know how
> it works for you.  
> 
> The new revision of bookmark.el is 1.60; here is the diff from 1.59 to
> 1.60:

This works fine.  It doesn't check vc anymore as far as I can tell.
  I don't know whether this is a problem, I just thought you might 
have forgotten about it.

> 
>    2002-06-07  Karl Fogel  <kfogel@red-bean.com>
> 
>    * bookmark.el (bookmark-file-or-variation-thereof): Just use
>    Info-suffix-list, as suggested by Stefan Monnier.
> 
> 
> $ cvs diff -c -r 1.59 -r 1.60 bookmark.el
> Index: bookmark.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/bookmark.el,v
> retrieving revision 1.59
> retrieving revision 1.60
> diff -c -r1.59 -r1.60
> *** bookmark.el	20 Dec 2001 18:32:12 -0000	1.59
> --- bookmark.el	8 Jun 2002 03:33:09 -0000	1.60
> ***************
> *** 1072,1090 ****
>   
>   
>   (defun bookmark-file-or-variation-thereof (file)
> !   "Return FILE (a string) if it exists in any reasonable variation, else nil.
> ! Reasonable variations are FILE.gz, FILE.Z, FILE.info, FILE.info.gz, etc."
> !   (cond
> !    ((file-exists-p file)                       file)
> !    ((file-exists-p (concat file ".Z"))         (concat file ".Z"))
> !    ((file-exists-p (concat file ".gz"))        (concat file ".gz"))
> !    ((file-exists-p (concat file ".z"))         (concat file ".z"))
> !    ((file-exists-p (concat file ".info"))      (concat file ".info"))
> !    ((file-exists-p (concat file ".info.gz"))   (concat file ".info.gz"))
> !    ((file-exists-p (concat file ".info.Z"))    (concat file ".info.Z"))
> !    ((file-exists-p (concat file ".info.z"))    (concat file ".info.z"))
> !    ((vc-backend file)                          file) ; maybe VC has it?
> !    (t                                          nil)))
>   
>   
>   (defun bookmark-jump-noselect (str)
> --- 1072,1089 ----
>   
>   
>   (defun bookmark-file-or-variation-thereof (file)
> !   "Return FILE if it exists, or return the first variation based on
> ! `Info-suffix-list' that exists, else return nil."
> !   (if (file-exists-p file)
> !       file
> !     (require 'info)  ; ensure Info-suffix-list is bound
> !     (catch 'found
> !       (mapc (lambda (elt)
> !               (let ((suffixed-file (concat file (car elt))))
> !                 (if (file-exists-p suffixed-file)
> !                     (throw 'found suffixed-file))))
> !             Info-suffix-list)
> !       nil)))
>   
>   
>   (defun bookmark-jump-noselect (str)
> 




-- 
The information in this e-mail is for use by the addressee(s) only. If you 
are not the intended recipient, please notify us immediately and delete the 
message from your computer. No liability or responsibility is accepted for 
viruses and it is your responsibility to scan attachments (if any). 
Opinions and views expressed in this email are those of the sender and 
do not reflect the opinions and views of antenova Ltd.