* Error in latest CVS version of fileio.c
@ 2002-06-04 18:25 David Ponce
2002-06-05 5:25 ` Pavel Janík
2002-06-06 12:04 ` Richard Stallman
0 siblings, 2 replies; 3+ messages in thread
From: David Ponce @ 2002-06-04 18:25 UTC (permalink / raw)
Cc: emacs-devel
Hi,
I found a bug in the latest CVS version of fileio.c. There is a
mismatch between the following call in fileio.c:
val = call4 (Vselect_safe_coding_system_function,
start, end, val, filename);
And the `select-safe-coding-system' declaration in
international/mule-cmds.el:
(select-safe-coding-system FROM TO &optional DEFAULT-CODING-SYSTEM
ACCEPT-DEFAULT-P FILE)
So make bootstrap failed to make leim with an "Invalid function" error
in `miscdic-convert' because `select-safe-coding-system' received a
filename as the ACCEPT-DEFAULT-P parameter (a function).
The following patch solved the problem:
*** fileio.c.ori Tue Jun 4 08:07:13 2002
--- fileio.c Tue Jun 4 13:55:55 2002
***************
*** 4674,4681 ****
if (!force_raw_text
&& !NILP (Ffboundp (Vselect_safe_coding_system_function)))
/* Confirm that VAL can surely encode the current region. */
! val = call4 (Vselect_safe_coding_system_function,
! start, end, val, filename);
setup_coding_system (Fcheck_coding_system (val), coding);
if (coding->eol_type == CODING_EOL_UNDECIDED
--- 4674,4681 ----
if (!force_raw_text
&& !NILP (Ffboundp (Vselect_safe_coding_system_function)))
/* Confirm that VAL can surely encode the current region. */
! val = call5 (Vselect_safe_coding_system_function,
! start, end, val, Qnil, filename);
setup_coding_system (Fcheck_coding_system (val), coding);
if (coding->eol_type == CODING_EOL_UNDECIDED
Sincerely,
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Error in latest CVS version of fileio.c
2002-06-04 18:25 Error in latest CVS version of fileio.c David Ponce
@ 2002-06-05 5:25 ` Pavel Janík
2002-06-06 12:04 ` Richard Stallman
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Janík @ 2002-06-05 5:25 UTC (permalink / raw)
Cc: emacs-devel
From: David Ponce <david@dponce.com>
Date: Tue, 04 Jun 2002 20:25:46 +0200
> I found a bug in the latest CVS version of fileio.c. There is a
> mismatch between the following call in fileio.c:
>
> val = call4 (Vselect_safe_coding_system_function,
> start, end, val, filename);
Thank you for your report, David. It should be fixed now.
--
Pavel Janík
Microsoft does write "free" software. Not free as in "free beer," or "free
speech," but "Free Tibet.".
-- Milan Svoboda in linux@linux.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Error in latest CVS version of fileio.c
2002-06-04 18:25 Error in latest CVS version of fileio.c David Ponce
2002-06-05 5:25 ` Pavel Janík
@ 2002-06-06 12:04 ` Richard Stallman
1 sibling, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2002-06-06 12:04 UTC (permalink / raw)
Cc: emacs-devel
Thanks for the fix. It looks like someone has already installed it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-06-06 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-06-04 18:25 Error in latest CVS version of fileio.c David Ponce
2002-06-05 5:25 ` Pavel Janík
2002-06-06 12:04 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).