unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Ponce <david@dponce.com>
Cc: emacs-devel@gnu.org
Subject: Error in latest CVS version of fileio.c
Date: Tue, 04 Jun 2002 20:25:46 +0200	[thread overview]
Message-ID: <3CFD062A.4090905@dponce.com> (raw)

Hi,

I found a bug in the latest CVS version of fileio.c.  There is a
mismatch between the following call in fileio.c:

     val = call4 (Vselect_safe_coding_system_function,
              start, end, val, filename);

And the `select-safe-coding-system' declaration in
international/mule-cmds.el:

(select-safe-coding-system FROM TO &optional DEFAULT-CODING-SYSTEM
ACCEPT-DEFAULT-P FILE)

So make bootstrap failed to make leim with an "Invalid function" error
in `miscdic-convert' because `select-safe-coding-system' received a
filename as the ACCEPT-DEFAULT-P parameter (a function).

The following patch solved the problem:

*** fileio.c.ori    Tue Jun  4 08:07:13 2002
--- fileio.c    Tue Jun  4 13:55:55 2002
***************
*** 4674,4681 ****
        if (!force_raw_text
        && !NILP (Ffboundp (Vselect_safe_coding_system_function)))
      /* Confirm that VAL can surely encode the current region.  */
!     val = call4 (Vselect_safe_coding_system_function,
!              start, end, val, filename);
 
        setup_coding_system (Fcheck_coding_system (val), coding);
        if (coding->eol_type == CODING_EOL_UNDECIDED
--- 4674,4681 ----
        if (!force_raw_text
        && !NILP (Ffboundp (Vselect_safe_coding_system_function)))
      /* Confirm that VAL can surely encode the current region.  */
!     val = call5 (Vselect_safe_coding_system_function,
!              start, end, val, Qnil, filename);
 
        setup_coding_system (Fcheck_coding_system (val), coding);
        if (coding->eol_type == CODING_EOL_UNDECIDED


Sincerely,
David

             reply	other threads:[~2002-06-04 18:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-04 18:25 David Ponce [this message]
2002-06-05  5:25 ` Error in latest CVS version of fileio.c Pavel Janík
2002-06-06 12:04 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CFD062A.4090905@dponce.com \
    --to=david@dponce.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).