From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: Small frameset bug Date: Mon, 3 Feb 2020 09:55:48 -0500 Message-ID: <3B26F6D5-7EE3-4523-A7D7-685D869C3C8E@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="36329"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lekktu@gmail.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 03 15:56:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iyd9a-0009LI-Dr for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Feb 2020 15:56:46 +0100 Original-Received: from localhost ([::1]:42634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyd9Z-0008PV-De for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Feb 2020 09:56:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47025) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyd8j-0006lw-Fz for emacs-devel@gnu.org; Mon, 03 Feb 2020 09:55:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyd8i-0003lV-B8 for emacs-devel@gnu.org; Mon, 03 Feb 2020 09:55:53 -0500 Original-Received: from mail-yw1-xc36.google.com ([2607:f8b0:4864:20::c36]:46236) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iyd8i-0003lP-6e for emacs-devel@gnu.org; Mon, 03 Feb 2020 09:55:52 -0500 Original-Received: by mail-yw1-xc36.google.com with SMTP id z141so13356342ywd.13 for ; Mon, 03 Feb 2020 06:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :cc:to; bh=3Qw0EjURncnMzVK1Cgg8Bo5DcT+QzG00nxUbUUlyyBQ=; b=cgTlIsDAHeIwukia5BdpntvYld5p3c1Vt/sU5lkN7HBgnGfST5r8Mzi3Vd8l1eh7Bq c2BQ79lxAhmLnR6Fn44RAIWz/NgVVsEy4YY8h/CZC+Fcxpu8nlMEqwrKhIJHm8MRg+Ap +Jy3h4y2NduC4RGuKXhmZmOAXV+VdSMUENk6Bvq9WPVykLU8ToFupYuaq/WE6veiDloF 1RleiWnrg3F9WQp1d26ADfPE4QGWgmopwCKnFn3BXeG7xb9uvAccXm8+q6JV68ukqvJT a2xJ+M1yy0+9Nv1xyekbrXQKKpCeufxSlWQorJm6sWuHBn04t2Hbx3yffmB0ESV8I4GS fUEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:cc:to; bh=3Qw0EjURncnMzVK1Cgg8Bo5DcT+QzG00nxUbUUlyyBQ=; b=Poh39mSsWeJxqw+tLiprBVDY+EdJGdTnvi6lZI4tG60DIhfRQYySqTRaE1XqdpmkGc W+8MDSh3nRGt/6on3N6S336HTj4Q6xticG5qSImd++HNKAisATIjZwKU2iG0hQRr1Rng /15lYSfdOrnZkWApTwIyOVCYvYIoYDaK0lwemQHR7N4lmU852Jn+36lwX4zZJDni0h+X mMDftevKvXBShZktqeBhy+GzlXIIbm/8a16SmixX4HS9x6uW//nyd2F6zsok7F2oecVf whch2QAoi6Kbbjupnki6Wj9YkgHFAPivlNDN2ltbbgUX7NANvVQF98Nj5YfBZxzWks7N YnHQ== X-Gm-Message-State: APjAAAUtZlBPGWK1OiD7pgZRfHfgiUT0Jx960xClD+mvxss26jIfFHG/ gOEjSDYXbg7Z1WsWXmQxiYtaz6iHrdo= X-Google-Smtp-Source: APXvYqxlfGK2/gyKJSvFOtV61CYSwKF5uA+J64qzLi5fdhWK8Btb2VLjLBza6E6wbdnZyEot4ESahQ== X-Received: by 2002:a81:4603:: with SMTP id t3mr348162ywa.97.1580741751192; Mon, 03 Feb 2020 06:55:51 -0800 (PST) Original-Received: from [192.168.0.101] (cblmdm134-228-15-233.buckeyecom.net. [134.228.15.233]) by smtp.gmail.com with ESMTPSA id a132sm8372993ywc.75.2020.02.03.06.55.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Feb 2020 06:55:50 -0800 (PST) X-Mailer: Apple Mail (2.3608.40.2.2.4) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244829 Archived-At: In `frameset--minibufferless-last-p`, the destructuring statements: (pcase-let ((`(,hasmini1 ,id-def1) (assq 'frameset--mini (car state1))) (`(,hasmini2 ,id-def2) (assq 'frameset--mini (car = state2)))) do not function as intended. Since the `assq` always produces = =E2=80=98frameset=E2=80=94mini` as its car, hasmini1/2 are always set to = this symbol. The subsequent `cond` still works as intended to sort = minibufferless frames last: (cond ((eq id-def1 t) t) ((eq id-def2 t) nil) ((not (eq hasmini1 hasmini2)) (eq hasmini1 t)) ((eq hasmini1 nil) (or id-def1 id-def2)) (t t)))) but the 3rd and 4th conditions are never met. This may cause confusion = for anyone trying to use the =E2=80=98frameset=E2=80=94mini frame = parameter.=