From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch Date: Mon, 22 Jul 2019 18:06:49 -0700 Organization: UCLA Computer Science Department Message-ID: <39d6b3e5-8ef1-c898-1fa2-223471d3a07f@cs.ucla.edu> References: <20190721193221.1964.53182@vcs0.savannah.gnu.org> <20190721193222.8C19E20BE2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="4028"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: emacs-devel@gnu.org To: Stefan Monnier , Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 23 03:07:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpjGg-0000wL-2z for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2019 03:07:02 +0200 Original-Received: from localhost ([::1]:38458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpjGe-0001ss-Sp for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 21:07:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36421) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpjGX-0001ri-1X for emacs-devel@gnu.org; Mon, 22 Jul 2019 21:06:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpjGW-0001re-3W for emacs-devel@gnu.org; Mon, 22 Jul 2019 21:06:52 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42294) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpjGV-0001qp-UH for emacs-devel@gnu.org; Mon, 22 Jul 2019 21:06:52 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D27AD161672; Mon, 22 Jul 2019 18:06:50 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id iBA2bm6SZ3Yh; Mon, 22 Jul 2019 18:06:50 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2B14D1616C2; Mon, 22 Jul 2019 18:06:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VVeUOkCpvVlD; Mon, 22 Jul 2019 18:06:50 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DA9C3161672; Mon, 22 Jul 2019 18:06:49 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238817 Archived-At: Stefan Monnier wrote: >> Shouldn't we count the allocations that happened while GC was >> inhibited and subtract them from consing_until_gc afterwards? > > I don't see why: they are counted already in consing_since_gc, no? Yes and no. The code keeps subtracting from consing_since_gc while GC is inhibited (and consing_since_gc is enormous); but when allow_garbage_collection is called, all those subtractions are lost. I installed the first part of Pip Cet's patch (rewritten slightly to I hope make it clearer) - thanks, Pip. The second part I didn't see the need for, as it made GC a tiny bit slower and arguably made GC harder to follow.