From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master b99ec5d 3/3: Work around __has_attribute bug in clang 3.4 Date: Sat, 23 Jan 2021 21:07:02 +0100 Message-ID: <39BEB930-68AE-4BDB-98F4-2FE0851F9A3C@acm.org> References: <20210122200300.770.63187@vcs0.savannah.gnu.org> <20210122200304.8BBE820A10@vcs0.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26089"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 21:08:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3PCl-0006gb-4I for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 21:08:19 +0100 Original-Received: from localhost ([::1]:41558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3PCk-0007LT-5d for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 15:08:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3PBg-0006ky-Ly for emacs-devel@gnu.org; Sat, 23 Jan 2021 15:07:14 -0500 Original-Received: from mail33c50.megamailservers.eu ([91.136.10.43]:59928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3PBe-0000p7-TB; Sat, 23 Jan 2021 15:07:12 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1611432425; bh=MwQZ4yxJtZZ8wMu1lIHc3OsGKLl+7J5ZwPHJ0cJYSQ0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=oQ9Ib/cIyDemfk+k5/mjTbxw1PPzNx900u3Exm068uJpgS76Hmx8EO137erfPYXRr aWgBWBKwKScIH1GpCLRLllEbINPagahPCCPOZFValzb2AgDi2ZtudDgBv/5oh1EhEe 38+nHQHpIgPm7afpKpn5yStRvGwvlQCtbXWMJFjQ= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10NK73pS021602; Sat, 23 Jan 2021 20:07:05 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F1F.600C81E9.002C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=aNeOVo1m c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=_GCPwFuMObHn-G8yUIYA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.43; envelope-from=mattiase@acm.org; helo=mail33c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263316 Archived-At: 23 jan. 2021 kl. 20.42 skrev Paul Eggert : > As I understand things Apple's __nonnull keyword used to mean = something else but collided with GNU's __nonnull macro, so they renamed = the keyword and put in a backward-compatibility macro for old Applish = code, but we don't need that macro and can just use __nonnull for our = own use. That is fine as long as the Gnulib cdefs.h is not included in = translation units also using Apple's framework headers, some of which do = use __nonnull instead of _Nonnull. I suppose it's a later worry since it = works for Emacs at the moment. > I attempted to fix the problem by installing the attached patch into = Gnulib, and then merged Gnulib into Emacs master. Please give it a try, = as I don't use macOS and so did not check the patch directly. Thank you! I can confirm that it works on macOS 10.14 (Mojave), Apple = clang version 11.0.0 (clang-1100.0.33.17).