From: Greg Minshall <minshall@acm.org>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: unsolicited patch to image-mode.el -- "fit to window"
Date: Fri, 24 Jul 2015 12:03:10 +0300 [thread overview]
Message-ID: <39315.1437728590@greg-minshalls-mbp.local> (raw)
In-Reply-To: Your message of "Fri, 24 Jul 2015 07:30:52 +0200." <55B1CD8C.3010203@gmx.at>
> If such code is not buggy, it should be changed only when and only by
> the person(s) working on it. Otherwise, as you say, it's too easy to
> introduce a bug in code that was correct before.
right, that seems like a good rule to me. so, i'd tend to leave my code
with the same pattern used in the rest of the file (i.e., using
(window-size-pixel-edges)), just for consistency. (but, even a very
light breeze would be enough to cause me to change it to use the clearer
calls, so feel free to so breathe.)
cheers, Greg
next prev parent reply other threads:[~2015-07-24 9:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 16:50 unsolicited patch to image-mode.el -- "fit to window" Greg Minshall
2015-07-12 16:56 ` Zack Piper
2015-07-13 5:19 ` Greg Minshall
2015-07-14 23:23 ` Stefan Monnier
2015-07-23 17:52 ` Greg Minshall
2015-07-23 18:26 ` martin rudalics
2015-07-24 3:46 ` Greg Minshall
2015-07-24 5:30 ` martin rudalics
2015-07-24 9:03 ` Greg Minshall [this message]
2015-07-25 8:27 ` martin rudalics
2015-07-25 8:31 ` martin rudalics
2015-08-19 14:17 ` Ted Zlatanov
2015-08-06 22:28 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39315.1437728590@greg-minshalls-mbp.local \
--to=minshall@acm.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).