From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] src/process.c: remove unnecessary setters Date: Mon, 29 May 2017 22:19:32 -0700 Organization: UCLA Computer Science Department Message-ID: <39094a23-3884-68b6-5633-25a6231460f5@cs.ucla.edu> References: <87shjnmeag.fsf@SoraLaptop> <87tw43t94q.fsf@SoraLaptop> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1496121590 761 195.159.176.226 (30 May 2017 05:19:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 05:19:50 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 Cc: Dmitry Antipov , emacs-devel@gnu.org To: Robert Cochran Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 30 07:19:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFZZJ-0008Kh-E2 for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 07:19:45 +0200 Original-Received: from localhost ([::1]:51488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFZZK-0003SS-1v for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 01:19:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFZZD-0003SN-6O for emacs-devel@gnu.org; Tue, 30 May 2017 01:19:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFZZ9-0000Y3-VY for emacs-devel@gnu.org; Tue, 30 May 2017 01:19:39 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38232) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFZZ9-0000Xr-P4 for emacs-devel@gnu.org; Tue, 30 May 2017 01:19:35 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 976C2160052; Mon, 29 May 2017 22:19:33 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qSQDdwRCnS5i; Mon, 29 May 2017 22:19:32 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C60E4160078; Mon, 29 May 2017 22:19:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gdAOMslpdvPb; Mon, 29 May 2017 22:19:32 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 88F47160052; Mon, 29 May 2017 22:19:32 -0700 (PDT) In-Reply-To: <87tw43t94q.fsf@SoraLaptop> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215342 Archived-At: Robert Cochran wrote: > Especially given that in 2015, INTERNAL_FIELD was removed (according to > ChangeLog.2 at any rate), it looks like the reason for the functions > removed to be abstracted away has long since become irrelevant. Thanks for looking into this. I had forgotten the details. I assume nobody needs those getters and setters any more, although it'd be nice to hear from Dmitry. I'll CC: him.