From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Davis Herring" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: RE: 23.0.50; savehist save invalid syntax Date: Mon, 10 Sep 2007 15:11:40 -0700 (PDT) Message-ID: <38309.128.165.123.18.1189462300.squirrel@webmail.lanl.gov> References: Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1189466501 2844 80.91.229.12 (10 Sep 2007 23:21:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Sep 2007 23:21:41 +0000 (UTC) Cc: sdl.web@gmail.com, Andreas Schwab , rms@gnu.org, emacs-pretest-bug@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 11 09:21:27 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IUyyj-0007wC-6F for ged-emacs-devel@m.gmane.org; Tue, 11 Sep 2007 08:12:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUrUM-0006Ge-Hm for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 18:12:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUrU2-00065J-AQ for emacs-devel@gnu.org; Mon, 10 Sep 2007 18:11:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUrU1-00064v-Gp for emacs-devel@gnu.org; Mon, 10 Sep 2007 18:11:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUrU1-00064j-Bi for emacs-devel@gnu.org; Mon, 10 Sep 2007 18:11:53 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUrU1-0001fx-4i for emacs-devel@gnu.org; Mon, 10 Sep 2007 18:11:53 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUrTd-0005gO-R6 for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 18:11:29 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IUrTx-0001fP-BF for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 18:11:52 -0400 Original-Received: from mailwasher.lanl.gov ([192.65.95.54] helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUrTw-0001f3-Nk; Mon, 10 Sep 2007 18:11:49 -0400 Original-Received: from mailrelay1.lanl.gov (mailrelay1.lanl.gov [128.165.4.101]) by mailwasher-b.lanl.gov (8.13.8/8.13.6/(ccn-5)) with ESMTP id l8AMBioV026715; Mon, 10 Sep 2007 16:11:44 -0600 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay1.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l8AMBeeN005227; Mon, 10 Sep 2007 16:11:40 -0600 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id l8AMBewt024765; Mon, 10 Sep 2007 16:11:40 -0600 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id l8AMBeRq024763; Mon, 10 Sep 2007 15:11:40 -0700 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.123.18 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Mon, 10 Sep 2007 15:11:40 -0700 (PDT) In-Reply-To: User-Agent: SquirrelMail/1.4.8-6.el3.2lanl X-Priority: 3 (Normal) Importance: Normal X-CTN-5-MailScanner-Information: Please see http://network.lanl.gov/email/virus-scan.php X-CTN-5-MailScanner: Found to be clean X-CTN-5-MailScanner-From: herring@lanl.gov X-Detected-Kernel: Linux 2.4-2.6 X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78518 gmane.emacs.pretest.bugs:19834 Archived-At: > I looked a bit closer at the rest as well, and I think that > `savehist-prin1-readable' needs to actually read what it prints (like it > did > before Davis's patch). It should raise an error (hence remove the written > entry and return nil) if either the write or the read fails. I'm not sure if you're saying it should try reading because of the Emacs 20 bug you're about to describe, or because you don't know (having written this before my reply to your previous mail) that printing now raises an error if the read would fail. > Emacs 20 serves as a good test for this, because it has a bug: If you do > `M-x cancel-debug-on-entry RET', then Emacs 20 inserts this invalid entry > in > the `command-history': (cancel-debug-on-entry ') - note the quote mark > before the right paren. This provoked a read error at load time, but the > attached patch correctly does not include that invalid entry in the saved > `command-history'. I happen to have a copy of Emacs 20 handy: it seems that that expression is (cancel-debug-on-entry (quote)). In Emacs 20, `pp' printed that erroneously, but `prin1' and friends printed that bogus expression correctly. So there are two bugs (whatever put that disembodied quote into `command-history', and `pp'), but I don't see the relevance to savehist, especially since the signaling print on which I made it rely will never exist in Emacs 20. > [savehist.el does not actually work with Emacs 20, for other reasons (e.g. > md5), but I have a version that does work, and I used that to test > `savehist-prin1-readable'.] What I just said about signaling prints should explain your test results, although I don't know how you got savehist to attempt to read output from `pp'. Feel free to keep the print/read trick for Emacs 20, of course! Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.