From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Davis Herring" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: RE: 23.0.50; savehist save invalid syntax Date: Mon, 10 Sep 2007 14:59:07 -0700 (PDT) Message-ID: <38272.128.165.123.18.1189461547.squirrel@webmail.lanl.gov> References: Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1189466194 1819 80.91.229.12 (10 Sep 2007 23:16:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Sep 2007 23:16:34 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, rms@gnu.org, sdl.web@gmail.com To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 11 09:16:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IUymN-0006Cs-LA for ged-emacs-devel@m.gmane.org; Tue, 11 Sep 2007 07:59:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUrI1-00056W-3G for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 17:59:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUrHx-00056G-IJ for emacs-devel@gnu.org; Mon, 10 Sep 2007 17:59:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUrHs-00052s-GA for emacs-devel@gnu.org; Mon, 10 Sep 2007 17:59:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUrHs-00052n-94 for emacs-devel@gnu.org; Mon, 10 Sep 2007 17:59:20 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUrHr-0008P9-VV for emacs-devel@gnu.org; Mon, 10 Sep 2007 17:59:20 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUrHU-0005M5-Iz for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 17:58:56 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IUrHo-0008OW-8J for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 17:59:19 -0400 Original-Received: from mailwasher.lanl.gov ([192.65.95.54] helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUrHn-0008No-Ii; Mon, 10 Sep 2007 17:59:16 -0400 Original-Received: from mailrelay1.lanl.gov (mailrelay1.lanl.gov [128.165.4.101]) by mailwasher-b.lanl.gov (8.13.8/8.13.6/(ccn-5)) with ESMTP id l8ALxAGZ023850; Mon, 10 Sep 2007 15:59:10 -0600 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay1.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l8ALx7oZ001259; Mon, 10 Sep 2007 15:59:07 -0600 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id l8ALx7tu022555; Mon, 10 Sep 2007 15:59:07 -0600 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id l8ALx7pX022553; Mon, 10 Sep 2007 14:59:07 -0700 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.123.18 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Mon, 10 Sep 2007 14:59:07 -0700 (PDT) In-Reply-To: User-Agent: SquirrelMail/1.4.8-6.el3.2lanl X-Priority: 3 (Normal) Importance: Normal X-CTN-5-MailScanner-Information: Please see http://network.lanl.gov/email/virus-scan.php X-CTN-5-MailScanner: Found to be clean X-CTN-5-MailScanner-From: herring@lanl.gov X-Detected-Kernel: Linux 2.4-2.6 X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78517 gmane.emacs.pretest.bugs:19833 Archived-At: > 1. The most common problem I've run into here is that strings with text > properties are printed so that they cannot be read - for example: > #("foobar" > 0 6 (face font-lock-comment-face)). As Andreas said, no problem here. > 2. I think your patch was missing a right paren here: > > (savehist-prin1-readable `(setq ,symbol ',(symbol-value symbol)))))) > > 3. I think your patch was missing inserting the second right paren and the > newline character here: > > (insert "))\n") > > 4. I think your patch was missing inserting the space, quote, and left > paren > here (and a newline is not needed here): > > (insert "(setq ") (prin1 symbol) (insert " '(") You're right, of course; I fixed some parentheses, but obviously didn't find all of the problems. But there was a reason for the newline: all elements but the first will start at the beginning of a line, so I thought it best that the first do so as well. I've adjusted my own copy appropriately, for when I find the time to write up the patch documentation. > 5. I don't see how the condition-case in `savehist-prin1-readable' can > work. > How would an `invalid-read-syntax' error ever be raised here? Isn't it > only > the Lisp reader that raises that error? I think the error type should be > just `error'. The applicability of the error symbol may be questionable, but there is no bug: with my patch to print.c (and `print-unreadable-function' bound to t), the Lisp printer raises that error if the Lisp reader -would- raise it. > 6. In keeping with the doc string, I replaced octal 600 with decimal 384 > as > the default value of `savehist-file-modes'. The doc string has to explain the variable's appearance to the user; in the code it's probably best to use the octal constant since that shows what's meant. I question why the docstring should mention its own default value, except perhaps to say that 384==0600 in case that happens to be its value. > 7. I wrapped a condition-case around the body of `savehist-autosave'. I > added this long ago to my version, but I cannot recall exactly why it was > needed. I can't see why that function should be particularly likely to throw, unless `savehist-minibuffer-history-variables' contained unprintable objects (and it should contain only symbols). If it does, it is presumably a bug to fix, yes? > 8. I left in your binding of `print-unreadable-function', but I did not > test > that part (I did not build Emacs from C sources). As stated just above, this is of course critical. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.