From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Davis Herring" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; find-func: can no longer find adviced subrs Date: Mon, 10 Sep 2007 13:54:56 -0700 (PDT) Message-ID: <38138.128.165.123.18.1189457696.squirrel@webmail.lanl.gov> References: <20070908033930.6065512A4546@localhost> <18146.57904.917867.570685@gargle.gargle.HOWL> Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1189464216 27685 80.91.229.12 (10 Sep 2007 22:43:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Sep 2007 22:43:36 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: raman@users.sourceforge.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 11 08:43:23 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IUxmC-0004iV-KT for ged-emacs-devel@m.gmane.org; Tue, 11 Sep 2007 06:55:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUqHq-0002Gw-7Y for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 16:55:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUqHn-0002Gk-CT for emacs-devel@gnu.org; Mon, 10 Sep 2007 16:55:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUqHk-0002Fb-GX for emacs-devel@gnu.org; Mon, 10 Sep 2007 16:55:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUqHk-0002FY-B3 for emacs-devel@gnu.org; Mon, 10 Sep 2007 16:55:08 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUqHj-0007qg-Uc for emacs-devel@gnu.org; Mon, 10 Sep 2007 16:55:08 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUqHM-0002cC-JW for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 16:54:44 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IUqHg-0007pU-3f for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 16:55:07 -0400 Original-Received: from mailwasher.lanl.gov ([192.65.95.54] helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUqHf-0007pG-IR for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 16:55:03 -0400 Original-Received: from mailrelay3.lanl.gov (mailrelay3.lanl.gov [128.165.4.104]) by mailwasher-b.lanl.gov (8.13.8/8.13.6/(ccn-5)) with ESMTP id l8AKt00V008431; Mon, 10 Sep 2007 14:55:00 -0600 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay3.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l8AKsuJc029193; Mon, 10 Sep 2007 14:54:56 -0600 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id l8AKsudB011169; Mon, 10 Sep 2007 14:54:56 -0600 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id l8AKsuaL011167; Mon, 10 Sep 2007 13:54:56 -0700 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.123.18 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Mon, 10 Sep 2007 13:54:56 -0700 (PDT) In-Reply-To: <18146.57904.917867.570685@gargle.gargle.HOWL> User-Agent: SquirrelMail/1.4.8-6.el3.2lanl X-Priority: 3 (Normal) Importance: Normal X-CTN-5-MailScanner-Information: Please see http://network.lanl.gov/email/virus-scan.php X-CTN-5-MailScanner: Found to be clean X-CTN-5-MailScanner-From: herring@lanl.gov X-Detected-Kernel: Linux 2.4-2.6 X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78511 gmane.emacs.pretest.bugs:19831 Archived-At: > the problem appears to stem from the fact that symbol-function on > an adviced subr now returns the compiled advice form, rather than > the # > -- this causes find-function-noselect to fail This should not be surprising: the symbol's function definition now -is- that advice form and not a subr. > the problem also shows up when you do describe-function on an > adviced subr -- the help buffer text wrongly identifies it as an > interactive function at the top of the help text. The advice form is an interactive function, and is correctly described as such. One can argue that the help system should be more aware of advice, but it is not necessarily trivial to distinguish between advice and an arbitrary lambda stored in a symbol's function cell. Perhaps `describe-function' should consult the `ad-advice-info' property on its argument when constructing its first line of output. `find-function' could do something similar. > Other parts of emacs still know it's a subr -- the bototm of the > help text says "this subr is adviced ..." That text is generated by the advice system and knows what the original function is. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.