unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-30 3fcec09f754 2/4: Add debugging function for treesit.c
Date: Sun, 8 Sep 2024 21:13:00 -0700	[thread overview]
Message-ID: <380D055D-88C3-4C9E-8926-1E4C11C20430@gmail.com> (raw)
In-Reply-To: <s1rr09tbhq8.fsf@yahoo.com>



> On Sep 8, 2024, at 8:58 PM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> branch: emacs-30
>> commit 3fcec09f754af9822339eff3ea15d43eb7d19014
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>> 
>>    Add debugging function for treesit.c
>> 
>>    * src/treesit.c (treesit_debug_print_parser_list): New function.
>> ---
>> src/treesit.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 47 insertions(+)
>> 
>> diff --git a/src/treesit.c b/src/treesit.c
>> index 6e806039df0..351bd65819a 100644
>> --- a/src/treesit.c
>> +++ b/src/treesit.c
>> @@ -485,6 +485,53 @@ treesit_initialize (void)
>> }
>> 
>> 
>> +/*** Debugging */
>> +
>> +void treesit_debug_print_parser_list (char *msg, Lisp_Object parser)
> 
> Please insert a newline between the return type and identifier name.
> Is this appropriate for Emacs 30?

Will do. This is for debugging a hang on emacs 30 (which I still haven’t figure out yet) (bug#72863). If it’s not appropriate for emacs-30, I can revert it and later put it on master. A debugging function won’t be called by any function so it shouldn’t disrupt anything. I’m only locally inserting calls to this function in various places for debugging.

Yuan


  reply	other threads:[~2024-09-09  4:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <172585397252.25544.14799687468267584593@vcs2.savannah.gnu.org>
     [not found] ` <20240909035253.23A45C41F2E@vcs2.savannah.gnu.org>
2024-09-09  3:58   ` emacs-30 3fcec09f754 2/4: Add debugging function for treesit.c Po Lu via Emacs development discussions.
2024-09-09  4:13     ` Yuan Fu [this message]
2024-09-09 11:55     ` Eli Zaretskii
     [not found] ` <20240909035253.077E8C41F21@vcs2.savannah.gnu.org>
2024-09-09 23:00   ` emacs-30 0fd259d166c 1/4: Fix elixir-ts-mode's range query john muhl
2024-09-11  3:08     ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=380D055D-88C3-4C9E-8926-1E4C11C20430@gmail.com \
    --to=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).