From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master ea93326: Add `union' and `intersection' to rx (bug#37849)
Date: Sun, 15 Dec 2019 20:23:17 +0100 [thread overview]
Message-ID: <379396AE-D709-4F6F-AE7C-30321A5452C4@acm.org> (raw)
In-Reply-To: <jwv36dlprsg.fsf-monnier+emacs@gnu.org>
15 dec. 2019 kl. 15.53 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
>> A bit overkill just for matching a set of constant strings, don't you think?
>
> I think there's a lot of implicit assumptions here.
> Yes, there are cases where you may want the "longest match" rule and
> where `posix-string-match` can be too costly, but the ones I can think
> of seem to be fairly contrived.
Perhaps I should have underlined that it is only literal strings that is of immediate concern, since that is what regexp-opt is used for. It is not a contrived situation to have a set of strings -- keywords, for instance -- not necessarily anchored by something else at the end. Unless it is known that no string is a prefix of another, the longest match is naturally desired.
next prev parent reply other threads:[~2019-12-15 19:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191210213842.5388.30110@vcs0.savannah.gnu.org>
[not found] ` <20191210213843.EB6A520A23@vcs0.savannah.gnu.org>
2019-12-10 21:52 ` master ea93326: Add `union' and `intersection' to rx (bug#37849) Stefan Monnier
2019-12-11 11:17 ` Mattias Engdegård
2019-12-11 15:10 ` Stefan Monnier
2019-12-12 22:48 ` Mattias Engdegård
2019-12-13 13:55 ` Stefan Monnier
2019-12-13 17:03 ` Mattias Engdegård
2019-12-13 17:13 ` Stefan Monnier
2019-12-13 17:43 ` Mattias Engdegård
2019-12-13 23:03 ` Stefan Monnier
2019-12-15 11:08 ` Mattias Engdegård
2019-12-15 14:53 ` Stefan Monnier
2019-12-15 19:23 ` Mattias Engdegård [this message]
2019-12-15 20:04 ` Stefan Monnier
2019-12-15 20:42 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379396AE-D709-4F6F-AE7C-30321A5452C4@acm.org \
--to=mattiase@acm.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).