From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Cc: "João Távora" <joaotavora@gmail.com>
Subject: cus-test fails from completion-category-overrides eglot adds
Date: Tue, 25 Oct 2022 21:47:41 +0200 [thread overview]
Message-ID: <3760C30F-C55E-4CB6-BA3B-E30D9BEC93BE@gmail.com> (raw)
The test-custom-opts test currently fails because eglot adds elements to `completion-category-overrides` that doesn't match its declared type.
While eglot also adds to `completion-styles-alist`, from which the type of `completion-category-overrides` is derived, this happens too late; the defcustom type is already set.
Most likely that type needs to be made dynamic (late-bound) in some way. A validation function would be one way, but it doesn't help with interactive customisation, does it? (I'm no defcustom expert and it shows.)
next reply other threads:[~2022-10-25 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 19:47 Mattias Engdegård [this message]
2022-10-25 21:19 ` cus-test fails from completion-category-overrides eglot adds João Távora
2022-10-25 22:48 ` Stefan Monnier
2022-10-26 6:22 ` Stefan Kangas
2022-10-26 9:05 ` Mattias Engdegård
2022-10-26 11:45 ` Stefan Monnier
2022-10-26 7:44 ` Michael Albinus
2022-10-26 9:39 ` João Távora
-- strict thread matches above, loose matches on Subject: below --
2022-10-26 11:35 Mauro Aranda
2022-10-26 12:18 ` Stefan Monnier
2022-10-26 14:35 ` Mauro Aranda
2022-10-26 12:51 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3760C30F-C55E-4CB6-BA3B-E30D9BEC93BE@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).