From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Average-user-facing interface for tree-sitter Date: Thu, 20 Oct 2022 16:06:50 -0700 Message-ID: <374026E1-4BFC-4F62-B62E-94F61F4BCFA9@gmail.com> References: <3A7E7CD1-74A7-4352-9DFE-FC982EAA398E@gmail.com> <87ilko9r9e.fsf@gnus.org> <9794E2EF-4DB5-4A04-90F0-3EB51E6BE008@gmail.com> <87977C2D-844B-4F4E-BEA4-8BCBFC8AE354@gmail.com> <6A0F847F-910D-449B-B461-466493CC9847@gmail.com> <87sfjmg69q.fsf@gnus.org> <21B2ADDF-70BC-46D4-98D6-41C5D0EF7D40@gmail.com> <87edv4l6iw.fsf@thornhill.no> <7E474686-A204-493C-A168-48EE4856DC8A@gmail.com> <87r0z3gcse.fsf@thornhill.no> <87pmemmklo.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Lars Ingebrigtsen , emacs-devel To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 21 01:09:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1olefH-000ALZ-Nf for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Oct 2022 01:09:27 +0200 Original-Received: from localhost ([::1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olefG-0005MP-1x for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 19:09:26 -0400 Original-Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olecu-0004jc-5u for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 19:07:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olecq-0004ix-2c for emacs-devel@gnu.org; Thu, 20 Oct 2022 19:06:56 -0400 Original-Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oleco-0003kD-E7 for emacs-devel@gnu.org; Thu, 20 Oct 2022 19:06:55 -0400 Original-Received: by mail-pg1-x530.google.com with SMTP id r18so894179pgr.12 for ; Thu, 20 Oct 2022 16:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6g/jaFFDY2CmflaPopKyDNWIH3A7o8m0kJRfD9a133o=; b=FKYZJOmwuK9mZOJfb7Qd3XmzS4wDVIQcdGffGLkj+vwxqe4kl/eobzI2yB1RJ4tSDu 8YN77tOUiERZLg6df5qT3zr5YHSLsuRT9nOyEeaCGhLJh6GvvT4XEU9VyLWvQuCfbJ/O Vczo5TEDhsKce+tKTdt5un1kI+GzEcmMAu0/koGCFq3XpDMm7RBQB1AaG1ZzbrUeoxJ1 B0FhLUeiUxFo+D9r6tU3on1fsDuQTFSFnZsIXktxiM4EDK0CmGiJKT4ZFeLMVSFkVqPa e34u/5UGkqiEYTwXxqR11SFmS0kMUMEt7q7jRh2iccpQl9kHv5ejpegRupR74xtOixiV ofCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6g/jaFFDY2CmflaPopKyDNWIH3A7o8m0kJRfD9a133o=; b=P7B7ejuqb4iWfiaPc3aZOpecrB73XP0ABdaM5Bcltf719CB8SoJ8jv4hqLpV6vwmoL IjnewGosdcqQbZaqps1olfqOv2DhpISHvWwMC8oLNwyHQZj/yAlqi96P83e3jRrw5Tx1 xJQnjZfyOw2/AxWEekEFJ9p86VvqSG5B3FV4KF2YYGRvxFIW2TaTuQQGWSoin1l8fwwK i1ew60C7LAbIAM4aVISjd4SNULuZH4MCtPMz+zhZbd/Fw6yKQ5GrKAGaSyRMF1xIfqh4 RjaWsj13lEUrw4uII0rzck9xDVpyU3QicADSGavONPm9LGNs6I0JUayPdjl072rfEJ0s w8nw== X-Gm-Message-State: ACrzQf3nNeLViexyQDa200AmdQ0KntGrj9fjmGGz1t9FCF+M9SQpmRNF kkW8wT4cCXl+8hx/GIUPbAw= X-Google-Smtp-Source: AMsMyM6TPZeGNzBg8JILRR9T38cnrTYurD2kq2A+ORQ2LCXA+rHqSTGwzQf4+dI99RkQpw+AwRUHOw== X-Received: by 2002:a65:6e4a:0:b0:438:874c:53fd with SMTP id be10-20020a656e4a000000b00438874c53fdmr14110460pgb.355.1666307212736; Thu, 20 Oct 2022 16:06:52 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id r10-20020aa7988a000000b0054cd16c9f6bsm13774876pfl.200.2022.10.20.16.06.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2022 16:06:51 -0700 (PDT) In-Reply-To: <87pmemmklo.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=casouri@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298181 Archived-At: > On Oct 20, 2022, at 11:10 AM, Theodor Thornhill = wrote: >=20 > Stefan Monnier writes: >=20 >>>> Yes, sorry, I made some further changes to js-mode. Could you have = a look >>>> and see if it makes sense? >>>>=20 >>> I'm not sure I really like the new changes. >>=20 >> [ Context: I'm largely to blame, I proposed the change. ] >>=20 >=20 > No worries :-) >=20 >>> Now we init everything in >>> js-mode in addition to everything treesitter related. So now stuff = like >>>=20 >>> ``` >>> (setq-local font-lock-defaults >>> (list js--font-lock-keywords nil nil nil nil >>> '(font-lock-syntactic-face-function >>> . js-font-lock-syntactic-face-function))) >>> (setq-local syntax-propertize-function #'js-syntax-propertize) >>> (add-hook 'syntax-propertize-extend-region-functions >>> #'syntax-propertize-multiline 'append 'local) >>> (add-hook 'syntax-propertize-extend-region-functions >>> #'js--syntax-propertize-extend-region 'append 'local) >>> (setq-local prettify-symbols-alist js--prettify-symbols-alist) >>>=20 >>> (setq-local parse-sexp-ignore-comments t) >>> ``` >>=20 >> Hmm... yeah, undoing those add-hook settings of various other = variables >> which treesit-mode doesn't use is a problem. We need to find >> a better way. >>=20 >>=20 >=20 > Yeah. Shouldn't it be possible to just have a global var instead of a > mode? That way we can just look for that variable when enabling the > mode, and avoid calling anything other than what we want. At least = for > the foreseeable future, enabling these per mode in the init file > shouldn't really be too much of a problem, IMO. When more users > actually get to try this we can get a feel for how the init should = best > be handled. >=20 > To me the '*-use-tree-siter' defcustoms was beautiful :) Back to centralized variable, perhaps? Yuan=