unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: emacs-devel@gnu.org, Protesilaos Stavrou <info@protesilaos.com>,
	Philip Kaludercic <philipk@posteo.net>
Subject: Re: [PATCH] completions-max-height
Date: Tue, 08 Mar 2022 09:05:29 +0100	[thread overview]
Message-ID: <3723C952-ECE7-467B-AE89-73EB0819B7F0@aol.com> (raw)
In-Reply-To: <87fsntvxg6.fsf@protesilaos.com>

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

I understand your intention, but in practice making this more complex is useless. The mini buffer is always down and making the completions to move somewhere else is uncomfortable and may require more lisp/emacs knowledge to change the default behavior from the user. Which is completely the opposite to my intention. Actually this same result may be reached with an advise as I discussed on yesterday on emacs help. But a simple custom is better.

I am totally fine if you propose something else more general if that don't forces the user to write a function to change a simple height. 


On March 8, 2022 6:13:13 AM GMT+01:00, Protesilaos Stavrou <info@protesilaos.com> wrote:
>On 2022-03-07, 22:10 +0000, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Ergus <spacibba@aol.com> writes:
>>
>>> Hi:
>>>
>>> Do you think that this may be added to vanilla?
>>
>> IMO it would be better if this could be generalised to something like
>> completion-display-buffer-action, so that you can decide where and how
>> the completion buffer is displayed.  Though I am uncertain if this might
>> have unintended side effects, as the behaviour seems to have been
>> hard-coded for a while.
>
>I agree with Philip.  Or go a step further and just let the Completions
>behave like other buffers so the user can contol its placement and
>parameters via the display-buffer-alist.
>
>-- 
>Protesilaos Stavrou
>https://protesilaos.com
>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[-- Attachment #2: Type: text/html, Size: 2222 bytes --]

  reply	other threads:[~2022-03-08  8:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220307210740.veiocemir46mmerk.ref@Ergus>
2022-03-07 21:07 ` [PATCH] completions-max-height Ergus
2022-03-07 22:10   ` Philip Kaludercic
2022-03-08  5:13     ` Protesilaos Stavrou
2022-03-08  8:05       ` Ergus [this message]
2022-03-08  8:47         ` Philip Kaludercic
2022-03-08 10:32           ` Ergus
2022-03-08 13:29           ` Ergus
2022-03-09 11:34             ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3723C952-ECE7-467B-AE89-73EB0819B7F0@aol.com \
    --to=spacibba@aol.com \
    --cc=emacs-devel@gnu.org \
    --cc=info@protesilaos.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).