Re: turn off safe-local-variable-values checking

["Stuart D. Herring" <herring@lanl.gov>]

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

[Original thread is at
http://lists.gnu.org/archive/html/emacs-devel/2006-04/msg00521.html.]

I wrote, a long time ago:

>>     table.el
>>     allout.el
>>     ediff*.el
>>
>> This is useful--I presume these bindings are safe,
>> so we should define predicates for the variables they bind.
>>
>> Would someone like to do that now, and ack?
>
> Interesting: each of those three files required a different approach.  I
> added predicates for time-stamp.el's local variables, putting reasonable
> limits on the integers.  Allout just needed to autoload its
> already-present safe-local declaration.  And ediff was using part of
> edebug which could really be used for evil, so I wrote a check for
> non-evil use and added that to the code for symbol properties.
>
> Patch attached, natch.

Oddly, most but not all of my patch was applied.  The part that wasn't
later became horribly out of date because of conflicting changes, but I've
resolved the conflicts several times and kept it alive, and am
resubmitting just the part that was missed as a diff against current
sources.  See the ChangeLog entry:

 	* files.el: Add predicates for time-stamp.el's file-local
 	variables (here, since it's never automatically loaded).

Assuming that there's nothing wrong with adding the rest of what was added
then, please install?

Davis

PS - Sadly, I was reminded of these changes by the recent thread
http://lists.gnu.org/archive/html/emacs-devel/2007-02/msg01042.html: there
was an insidious bug in the part of my patch that was applied!

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

[-- Attachment #2: local-variables-2.patch --]
[-- Type: application/octet-stream, Size: 1105 bytes --]

Index: files.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/files.el,v
retrieving revision 1.885
diff -c -r1.885 files.el
*** files.el	25 Feb 2007 09:24:11 -0000	1.885
--- files.el	1 Mar 2007 00:20:43 -0000
***************
*** 2449,2454 ****
--- 2448,2464 ----
  	(left-margin                     . integerp) ;; C source code
  	(no-update-autoloads             . booleanp)
  	(tab-width                       . integerp) ;; C source code
+ 	(time-stamp-inserts-lines        . t)
+ 	(time-stamp-line-limit           . (lambda (val)
+ 					     (and (integerp val)
+ 						  (not (zerop val))
+ 						  (<= (abs val) 1000))))
+ 	(time-stamp-count                . (lambda (val) (and (integerp val)
+ 							       (<= val 100))))
+ 	(time-stamp-end                  . stringp)
+ 	(time-stamp-format               . stringp)
+ 	(time-stamp-pattern              . string-or-null-p)
+ 	(time-stamp-start                . stringp)
  	(truncate-lines                  . booleanp))) ;; C source code
  
  (put 'c-set-style 'safe-local-eval-function t)

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel