From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Wed, 31 Aug 2022 14:57:38 +0300 Message-ID: <3716f90c-3699-4ed7-03c8-f680dc8b206d@yandex.ru> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <83zgfksllp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2683"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: luangruo@yahoo.com, ams@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 14:03:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTMRP-0000a1-M5 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 14:03:31 +0200 Original-Received: from localhost ([::1]:35734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTMRO-0000Df-H5 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 08:03:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMMG-0004X7-Lw for emacs-devel@gnu.org; Wed, 31 Aug 2022 07:58:12 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:45815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTMME-0007Qc-Aq; Wed, 31 Aug 2022 07:58:12 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id bd26-20020a05600c1f1a00b003a5e82a6474so7824476wmb.4; Wed, 31 Aug 2022 04:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=cvgMEFeKJqfIseIX1KWKX9aCnefHFAoBGdqHc+BMXwY=; b=Vs5o6vLGHzsHpXzCGzdpU7B0wzSQ1wuaXB/Z2I+6/EFp12I7MrbKijzgfFQS3MWe5U XjQ8vFGmU1bDUgjYiC/dYDxmomksn7G2zwmIu6yYpnv926kqQBKO8ZnU4rfE1jesEbrl 76RD48cd1BRRwc0CCVdsQrCAPWXE3wptY8EXjFSmv/pLYYuyhs5WuFE8A8aadu3z7rmo MUDwb34rqY3VXDN+ZfFkxHkMPkB4EcdVshuxqVotXh42IcrErFhVJ7og4hXIEP7f9RhX ZHYE+4TS1AImKZ+Rw/CWPZ0qG7x0epyMNktawxOvuD0aCc+Uk4iC+ahOUd7jcaO/SVZt hv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=cvgMEFeKJqfIseIX1KWKX9aCnefHFAoBGdqHc+BMXwY=; b=HWsqaxAg/DgbS0hdYMtYsb/k0l+CYMi/tgFoHvINvhGoCdJ9VIC0xsmWB49w79T/ut 19XUFouvTQUpUzD+d8JMppiKjjEPXer5rrYFUkNlSg18t+o8pYyx+Kn1kgC2rkmDiAIi SJEBWN+mA5x7++SePheKmmwogDL6sLe4/QbVbUTYDRfPmT3SZKqFwzvmCD7pcEGz2Uv/ q04zRbc/XU90HjPs6DRQhP1bJXkxQ+RWYtkUWYieQQIPLJ7DoGTxq/dNfrNIXwYavFvV iDSMxJKuS8s9Q2EHF+lrELNHYHUjnensKA75NUAepjvLKVf0nQY3SSMwjI90TLgP5s6Z t1dg== X-Gm-Message-State: ACgBeo1ubHKoY//0DNuwN5u3gUz2VYccS4ZI8FeR2k0mCxFjNZJxQywg +4qayr2MP/B2CwyTjOFDtS/z710FW7c= X-Google-Smtp-Source: AA6agR4xNbM0eIguSK/gNNtla1cbUYrrPNaFNmwVjweWmSAIOTpFDxoOCnIa28QtY/vnGWhTkeaQuw== X-Received: by 2002:a05:600c:3c8a:b0:3a6:7719:6118 with SMTP id bg10-20020a05600c3c8a00b003a677196118mr1813631wmb.199.1661947061834; Wed, 31 Aug 2022 04:57:41 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id ba18-20020a0560001c1200b002250fa18eb6sm5346959wrb.71.2022.08.31.04.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 04:57:40 -0700 (PDT) Content-Language: en-US In-Reply-To: <83zgfksllp.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=raaahh@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294422 Archived-At: On 31.08.2022 14:23, Eli Zaretskii wrote: >> Date: Wed, 31 Aug 2022 05:32:42 +0300 >> Cc: "Alfred M. Szmidt" , eliz@gnu.org, larsi@gnus.org, >> juri@jurta.org, emacs-devel@gnu.org >> From: Dmitry Gutov >> >>>> I can look into adapting this approach for other VCS if nobody beats >>>> me to it. As long as we fundamentally agree on the behavior. >>> Thank you. >> >> This seems to work. > > Thanks. > >> + (dolist (f files) >> + (copy-file (expand-file-name f root) >> + (expand-file-name f tmpdir))) > > What if f includes leading directories, as in "lisp/foo.el"? If > tmpdir doesn't have a subdirectory 'lisp', the copy-file will fail, > no? That's unfortunate. >> + (unwind-protect >> + (let ((default-directory root)) >> + (dolist (f files) >> + (with-current-buffer (get-file-buffer f) > ^^^^^^^^^^^^^^^^^^^ > This assumes that all the files are visited in buffers? Is that > guaranteed? Right. That might account for that one-weird-bug I've seen once.