From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Tue, 10 Dec 2024 14:16:01 -0500 Message-ID: <36a57a48-76ab-4254-b3bc-af1fff2d9b98@app.fastmail.com> References: <87ldx0vufd.fsf@sebasmonia.com> <8fde5a67-f778-f0c8-bcdd-ece08c95d369@gmail.com> <87h67nm4su.fsf@sebasmonia.com> <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37911"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Adam Porter" , emacs-devel@gnu.org, "Eli Zaretskii" To: "Jim Porter" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 10 20:17:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tL5jQ-0009fg-92 for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Dec 2024 20:17:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tL5iv-0006RM-UB; Tue, 10 Dec 2024 14:16:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tL5if-0006L0-Cb for emacs-devel@gnu.org; Tue, 10 Dec 2024 14:16:37 -0500 Original-Received: from fhigh-a5-smtp.messagingengine.com ([103.168.172.156]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tL5ib-0001a7-8E; Tue, 10 Dec 2024 14:16:27 -0500 Original-Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 408E11140173; Tue, 10 Dec 2024 14:16:22 -0500 (EST) Original-Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-12.internal (MEProxy); Tue, 10 Dec 2024 14:16:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1733858182; x=1733944582; bh=/xb+cRCplgWorx3+v3VAyRFJ2GSV/qLM //77myiueKk=; b=lggMCB95elLIkv8VKNy0RXbigUL3cA60raT0xKb4UoTI9we4 ECbra69uMEb/pTc3y+aUIHBo04U2yexu/6vKLUg3SdQk3dlSwgNVxCFLPjrzA3rx i2BDnnVykxf2pz2K5rJySbighl8UFFB+qQtoYkehJKKgehe5LFNbJjBur0takSXF Ub+8haeh5ee+fv93QsE33HYfsX5NPXcRsrqsUpdIBWxmaEPesWTd184pTopH7z9v C1CZCh2IM+TvIjvFcn9XByAvvBEFtuQOaOVBSynLki/+iFNAlkHo6uBK/ivZF/RE JkPCLshWR97jjqPELndGDWl16Bf2DlNrmVPviw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733858182; x= 1733944582; bh=/xb+cRCplgWorx3+v3VAyRFJ2GSV/qLM//77myiueKk=; b=Z dJ+4q1ND7qd5ASIyeO08vWS7ND0aZc74upxrOMny7rtU4Xgh5XACnUkfMSGxVdRr m6jjD2ke7JOknDeGKyIdcKFHkQ8E0pN5l+o9KckWgKvqy08k3YFaQJ+dtDn3NCL+ +SNySS9LByfMlN3BB94N0hdTQRKA/dP15UXKosqNl2fbiprGlGazz29jfwM6OrPs nFWbdBW+Rq1+aYqpiMT92Qv7jz3/2QiJfonTih7tvo/klKZ+LWprucYCKts/mLHG f9eIczbsxZQGBLKR0nWv/v0ehvKehu8mAZ0B9qYY2J7cI7jK50rjnDKvFyV1xofY SNiZyz5dgI4DQopduJZaw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeekgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdej necuhfhrohhmpefuvggsrghsthhijohnucfoohhnvogruceoshgvsggrshhtihgrnhessh gvsggrshhmohhnihgrrdgtohhmqeenucggtffrrghtthgvrhhnpeelteeigffhffdtieet vdeluddvieffueegffevtedttdfghefgfedtgffhtdelteenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsvggsrghsthhirghnsehsvggsrghs mhhonhhirgdrtghomhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpd hrtghpthhtoheprggurghmsegrlhhphhgrphgrphgrrdhnvghtpdhrtghpthhtohepjhhp ohhrthgvrhgsuhhgshesghhmrghilhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuh drohhrghdprhgtphhtthhopegvmhgrtghsqdguvghvvghlsehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: iab2c46da:Fastmail Original-Received: by mailuser.phl.internal (Postfix, from userid 501) id D6EA71C20067; Tue, 10 Dec 2024 14:16:21 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> Received-SPF: pass client-ip=103.168.172.156; envelope-from=sebastian@sebasmonia.com; helo=fhigh-a5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326309 Archived-At: On Sun, Dec 8, 2024, at 11:52 PM, Jim Porter wrote: > On 12/1/2024 2:12 PM, Sebasti=C3=A1n Mon=C3=ADa wrote: > > Generalizing this feature can be challenging in that different types= of > > information could need very different handing. >=20 > I think in this case, I'll defer to you and Adam (and Eli) about the=20 > best path forward here. The existing behavior is a bit odd, and since = I=20 > don't use EWW's bookmarks, I don't have a good sense of the right way = to=20 > improve things here. Or in other words, I don't have any objections to=20 > the code, but I'm not confident that I know enough about this corner t= o=20 > do a properly thorough review. Will submit a patch ASAP to include a column "Order" ("navigation order"=20 is just too long, and I don't think users would associate it with M-n=20 and M-p "navigation"). And then we don't need a "remove sort" binding. Thank you everyone for your feedback!