From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Martin Fredriksson Newsgroups: gmane.emacs.devel Subject: window.c: suggested patch window_scroll_pixel_based Date: Sun, 29 Dec 2002 02:59:49 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <36895EE4-1AD1-11D7-8795-003065478022@crt.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v551) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1041127266 19058 80.91.224.249 (29 Dec 2002 02:01:06 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 29 Dec 2002 02:01:06 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18SSlC-0004xF-00 for ; Sun, 29 Dec 2002 03:01:02 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18SSm4-0000m1-00 for ; Sun, 29 Dec 2002 03:01:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18SSkv-0008VQ-0C for emacs-devel@quimby.gnus.org; Sat, 28 Dec 2002 21:00:45 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18SSkI-000854-00 for emacs-devel@gnu.org; Sat, 28 Dec 2002 21:00:06 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18SSjv-0007Mo-00 for emacs-devel@gnu.org; Sat, 28 Dec 2002 20:59:47 -0500 Original-Received: from nic.crt.se ([193.12.107.10]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18SSjm-0006oD-00 for emacs-devel@gnu.org; Sat, 28 Dec 2002 20:59:34 -0500 Original-Received: from mail.crt.se (postiljon.crt.se [172.16.1.14]) by nic.crt.se (Postfix) with ESMTP id 8FEAE52BD for ; Sun, 29 Dec 2002 02:59:32 +0100 (MET) Original-Received: from crt.se (stargate.crt.se [172.16.0.11]) by mail.crt.se (Postfix) with ESMTP id 490A51DE9 for ; Sun, 29 Dec 2002 02:59:31 +0100 (MET) Original-To: emacs-devel@gnu.org X-Mailer: Apple Mail (2.551) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10363 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10363 I suggest following patch to window.c (window_scroll_pixel_based), to make 'scroll-down' be able to reach the start of the buffer. This patch partly backs out of 1.433 (rms, 2002/12/23). I apologize if I have misunderstood the issue. I have verified the patch on OpenBSD/X11 and OSX/Carbon. Should I have reported this as a bug (to emacs-pretest-bug) instead? /m Index: window.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/window.c,v retrieving revision 1.433 diff -u -r1.433 window.c --- window.c 23 Dec 2002 18:04:45 -0000 1.433 +++ window.c 29 Dec 2002 01:55:05 -0000 @@ -4149,7 +4149,7 @@ /* End if we end up at ZV or BEGV. */ if ((n > 0 && IT_CHARPOS (it) == ZV) - || (n < 0 && IT_CHARPOS (it) == BEGV)) + || (n < 0 && IT_CHARPOS (it) == CHARPOS (start))) { if (IT_CHARPOS (it) == ZV) {