From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.devel Subject: [PATCH 2/7] Assert not local-variable-p after setq in let_default binding Date: Tue, 23 Mar 2021 23:11:52 -0400 Message-ID: <367421379cfc4aeae036ca786f0a0aa6dc4ce202.1616554376.git.sbaugh@catern.com> References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13812"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Spencer Baugh , Eli Zaretskii , Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 24 04:15:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOtzG-0003TQ-LF for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 04:15:14 +0100 Original-Received: from localhost ([::1]:53276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOtzF-0001Oe-KL for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Mar 2021 23:15:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOtwP-000690-6U for emacs-devel@gnu.org; Tue, 23 Mar 2021 23:12:17 -0400 Original-Received: from venus.catern.com ([68.183.49.163]:45422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOtwI-0000j4-74; Tue, 23 Mar 2021 23:12:16 -0400 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1616555529; bh=qzUVHpBmpIR6tPGMpTLZTsgkrTUA5TYlhPVtbcpOogI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GuZ1F3PjcDvoCEBAVORTajF6tUxdNu/aRQXpTNEWPt/l6tb8rWXEpxJpJeKpn1YSA KcuNrQ5DqNde7fe2QamKQYykqCYNcPc3CcSU8+vWiL3J12ty0SGhSzzgxPLBDsBszK 8tvdYZujjx0Nweo3HTVfn08fhV4s0zfYZY707ZaI= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 28A352E66F6; Wed, 24 Mar 2021 03:12:09 +0000 (UTC) X-Mailer: git-send-email 2.28.0 In-Reply-To: Received-SPF: pass client-ip=68.183.49.163; envelope-from=sbaugh@catern.com; helo=venus.catern.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266909 Archived-At: Breaking this is a likely way to break this test, so this saves a bit of time in debugging. * test/src/data-tests.el (data-tests--let-buffer-local): Add assertion to test. --- test/src/data-tests.el | 1 + 1 file changed, 1 insertion(+) diff --git a/test/src/data-tests.el b/test/src/data-tests.el index d0cb87293f..b1e5fa0767 100644 --- a/test/src/data-tests.el +++ b/test/src/data-tests.el @@ -358,6 +358,7 @@ comparing the subr with a much slower lisp implementation." (should (equal (symbol-value var) 42)) (should (equal (default-value var) (symbol-value var))) (set var 123) + (should (not (local-variable-p var))) (should (equal (symbol-value var) 123)) (should (equal (default-value var) (symbol-value var)))) ;bug#44733 (should (equal (symbol-value var) def)) -- 2.28.0