From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Checking in files with trailing white space Date: Mon, 12 Dec 2016 23:31:42 -0800 Organization: UCLA Computer Science Department Message-ID: <366009d8-72f4-2f85-103c-214a5e111e77@cs.ucla.edu> References: <20161211133110.GB14084@acm.fritz.box> <20161212221642.GA4361@acm.fritz.box> <83wpf4bj26.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1481614358 8546 195.159.176.226 (13 Dec 2016 07:32:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Dec 2016 07:32:38 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 Cc: acm@muc.de, larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 13 08:32:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGhZf-0000XT-5I for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2016 08:32:31 +0100 Original-Received: from localhost ([::1]:35891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGhZg-0007Se-3K for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2016 02:32:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGhZ3-0007SY-5k for emacs-devel@gnu.org; Tue, 13 Dec 2016 02:31:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGhZ2-0008Bt-3M for emacs-devel@gnu.org; Tue, 13 Dec 2016 02:31:53 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45570) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGhYx-00089r-EG; Tue, 13 Dec 2016 02:31:47 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F1B9D160051; Mon, 12 Dec 2016 23:31:43 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ApbozLdoAHhK; Mon, 12 Dec 2016 23:31:42 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AA764160057; Mon, 12 Dec 2016 23:31:42 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ux7RjLyeeQCr; Mon, 12 Dec 2016 23:31:42 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 83E37160051; Mon, 12 Dec 2016 23:31:42 -0800 (PST) In-Reply-To: <83wpf4bj26.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210396 Archived-At: Eli Zaretskii wrote: >> I'd rather avoid committing binary data. It's easier to read >> and review text files, given the tools we have. Any tests that require >> binary data can generate the data when the test is run. > How would you generate the likes of test/manual/etags/ETAGS.good_1? That one is not a problem. By "binary data" I meant files that are not va= lid=20 UTF-8 text, and that file consists entirely of UTF-8 text. An example of trouble is test/manual/etags/f-src/entry.strange.gz. Instea= d of=20 committing the gzipped file, I'd commit the original text file 'entry.str= ange',=20 and compress a copy as part of the test. To see an example problem when binary data is committed, visit this URL: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D6db72771cc08e719a= 08f56db8abd7cefef9c8c99 Because that commit installed some Latin-1 text, the body of that web pag= e=20 contains a mixture of UTF-8 and Latin-1. The web page is labeled as UTF-8= , so=20 the result works poorly with browsers (Firefox displays mojibake lines li= ke=20 "+2=EF=BF=BD4=EF=BF=BDbb*=EF=BF=BDabbbc=EF=BF=BD"). I fixed this particul= ar problem just now in master by=20 changing that file to use UTF-8, which works just as well for the Emacs t= est in=20 question.