From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Implement fast verisons of json-parse functions Date: Sun, 31 Mar 2024 12:48:53 -0500 Message-ID: <365d88a1-c14f-4427-96ee-149b5b52b713@alphapapa.net> References: <86zfufasz6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33716"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org, geza.herman@gmail.com, mattiase@acm.org To: eliz@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 31 19:49:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqzJe-0008Tj-BN for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Mar 2024 19:49:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqzIj-0008Uu-K6; Sun, 31 Mar 2024 13:49:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqzIi-0008Ug-Cp for emacs-devel@gnu.org; Sun, 31 Mar 2024 13:49:00 -0400 Original-Received: from bee.birch.relay.mailchannels.net ([23.83.209.14]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqzIg-0000GG-P7; Sun, 31 Mar 2024 13:49:00 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B02E1C171E; Sun, 31 Mar 2024 17:48:55 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a273.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4437AC1794; Sun, 31 Mar 2024 17:48:55 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1711907335; a=rsa-sha256; cv=none; b=6Iad33RQfevxRYQr88U+nLDino032CdHwGIvpOZb5j7MnXmOhECcbn38pTLEJ8X6dgfcpM FHMT3luI9yeiO24wmcywBU7tzbSQpCH8z4vg5yEQmPnWXkyWrx5sbJLDmaoQwufjgb4aUX w6XHIT1/VQ/OMNfMPvzi7rZHYy1/pNelCegdr16EJn+p1xmrFIURO2KQ7uP5nyB40EduMy MMc97tx+jWWdMvD5z0BzrU0jZnqdh/XejAt+XTdH9+hZQALd6SPYSoyIWkpm6nwf7mZ9No QoZUgl452tjM0PZPAOZxTSY5fR9JvVAtbqE0slf45pkIxcVAk0fF1nIKynKe+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1711907335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pHmF2KqJb/Tv2DucUZ0//jBpSPNBZvLnDFot4mhasLI=; b=Dd1OKWL/w1xwy6Lx5MYMKmzDdUJxPtNxTg+1aQa4ttEMgBsSlwF/XKYhyFriSKGTwfC297 cwatD8Yu0hkd76jIAUXHGay3w8TIS8MG3HWDMfzY8+I/9CsdBw9OUnJy+VO6TXhyA7Znd2 2hjkgd/9wmM0l+cEeSV3KxE19muU0K/Rzo18dWUu7S3C0a6OqOUZOFItCg3C8JnjxLECrZ 1vI8FksjHvz+4sC2PAFn2zSSk8EkjIfz6zjRtAHAtYCwIBiZWwSJHRrWTeYXLdYfEwljAa qadtAW6yjcDtS5IN/XcXfW1mUoOzIeiWAQ5ZNAC1QBTdw67C3WmcRGOShiFk7g== ARC-Authentication-Results: i=1; rspamd-699949c56f-q6hmc; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Wiry-Print: 790779130f75adf6_1711907335519_3669408599 X-MC-Loop-Signature: 1711907335519:2160620299 X-MC-Ingress-Time: 1711907335519 Original-Received: from pdx1-sub0-mail-a273.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.117.91.86 (trex/6.9.2); Sun, 31 Mar 2024 17:48:55 +0000 Original-Received: from [10.43.1.194] (unknown [193.56.116.15]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a273.dreamhost.com (Postfix) with ESMTPSA id 4V71pt46Yjz3Q; Sun, 31 Mar 2024 10:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1711907335; bh=pHmF2KqJb/Tv2DucUZ0//jBpSPNBZvLnDFot4mhasLI=; h=Date:To:Cc:Subject:From:Content-Type:Content-Transfer-Encoding; b=mIOA0KPrcpqTiIKIaAiTYGax3F6Eb/fVbLlaphAD98OUOD1t3Dhxn0CY7ADa6UZst kG7ODg4RpHvhoERUP/GbrauA7nu5rdwJY0iy4sV+hOqPerm6uI7HB7AekFqfmCAweY mRK1PO+s/56zBX9O4AWcsqHiCckAOOY/LgChxxrD/vFQ2+G7CarAWWbVjEqkMVx7P2 ICE7ZBnE8B7IoJxrFVFrKf6y5nFdrWN43Mh1zGhZjxekcrFCnrFhNDxOzmnOSRR/6/ 6HD5fV/dWVOVlHoDqNmN3r8SMiz2l8iyVtXTCHDQWZYr9hVQVldNvnoaQT466gRMpi th0RT79uAweOg== Content-Language: en-US In-Reply-To: <86zfufasz6.fsf@gnu.org> Received-SPF: neutral client-ip=23.83.209.14; envelope-from=adam@alphapapa.net; helo=bee.birch.relay.mailchannels.net X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317433 Archived-At: Hi Eli, > Well, it's "kind-of" wrong argument: a string with embedded null > bytes. But I'm also interested to hear from Mattias on this (and from > anyone else who might have an opinion about the kind of error we > should signal in this case). Well, since you asked: I tend to agree with Géza that a string containing a null byte is less of a wrong-type-argument and more of a parsing or decoding error. I think of a wrong-type-argument as, e.g. nil instead of a string, etc. IOW, an argument that's wrong on its face, by virtue of its type, rather than any internal characteristics. --Adam