From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Bruno Haible Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg Date: Tue, 02 May 2017 23:55:50 +0200 Message-ID: <3590215.6Xrt2mkima@omega> References: <20170427222412.28742.14016@vcs0.savannah.gnu.org> <80850259-8972-19b3-6435-2b8b9cc2319b@cs.ucla.edu> <83bmrbi3so.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Trace: blaine.gmane.org 1493762181 9584 195.159.176.226 (2 May 2017 21:56:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 May 2017 21:56:21 +0000 (UTC) User-Agent: KMail/5.1.3 (Linux/4.4.0-75-generic; KDE/5.18.0; x86_64; ; ) Cc: bug-gnulib@gnu.org, kbrown@cornell.edu, emacs-devel@gnu.org To: Eli Zaretskii , Paul Eggert Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Tue May 02 23:56:14 2017 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5fmH-0002MW-Un for gnu-bug-gnulib@m.gmane.org; Tue, 02 May 2017 23:56:14 +0200 Original-Received: from localhost ([::1]:33833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5fmN-00017Q-Nz for gnu-bug-gnulib@m.gmane.org; Tue, 02 May 2017 17:56:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5fm8-000160-7Y for bug-gnulib@gnu.org; Tue, 02 May 2017 17:56:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5fm7-00055j-4l for bug-gnulib@gnu.org; Tue, 02 May 2017 17:56:04 -0400 Original-Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::1]:36250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d5fm2-00053r-T3; Tue, 02 May 2017 17:55:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1493762156; l=2625; s=domk; d=clisp.org; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Date:Subject:Cc:To:From; bh=gDzt4r/4kchcaGKLlPoW+PyS41mElzQ8+J3KHJx3j7U=; b=jlusBC21jd4D1KwXHtYsJ4Le086dZ0dVcx1CrZOkkxaXG48ZAeG0r8bdgeIs+Qgu5b IZNIPRxTbhZy1mS9gx0bkOLggvvYKiI8kyB9P3hyAqbQcGaU4CpCI/k/eo7DhLbMJhSw Tk9RULxyhjrT8RF6f1XzgfiZRZXIINOKeDT2w= X-RZG-AUTH: :Ln4Re0+Ic/6oZXR1YgKryK8brksyK8dozXDwHXjf9hj/zDNRavI44sA= X-RZG-CLASS-ID: mo00 Original-Received: from bruno.haible.de (dslb-088-068-034-000.088.068.pools.vodafone-ip.de [88.68.34.0]) by smtp.strato.de (RZmta 40.6 DYNA|AUTH) with ESMTPSA id k0403bt42LtppOz (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Tue, 2 May 2017 23:55:51 +0200 (CEST) In-Reply-To: <83bmrbi3so.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 2a01:238:20a:202:5300::1 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:37216 gmane.emacs.devel:214527 Archived-At: Paul Eggert wrote: > I'd like Bruno's opinion on the macro clash The common idiom is "#define WINDOWS_LEAN_AND_MEAN". This can be seen by comparing the number of hits of two web searches: https://www.google.de/search?q=%22define+windows_lean_and_mean%22 https://www.google.de/search?q=%22define+windows_lean_and_mean+1%22 > and on the attached patch for the > msvc-nothrow.h issue, a patch that I installed into Gnulib and into Emacs master The patch is fine with me: it has no drawbacks for other packages. However, it would be good to know what qualms you have with the msvc-nothrow module. Should Emacs be built with mingw, not MSVC? Is an EBADF situation never going to occur in Emacs anyway? Are the portability efforts for mingw and MSVC in Gnulib useless for Emacs, because on native Windows Emacs uses its own w32.c instead anyway? Does Emacs have other requirements I don't know about? Eli Zaretskii wrote: > That "other way" is the implementation of fdutimens in Emacs's w32.c. > Perhaps Bruno could look at that implementation and comment on its > merits and demerits vs the Gnulib implementation 1) The Emacs w32.c ports to Windows98 as well, whereas Gnulib currently assumes Windows XP at least (and will soon move to Windows 7, I guess - namely when no one has a test machine with Windows XP any more). Merit or demerit? Opinion? 2) The Emacs w32.c has an option to use the "W" suffixed Windows APIs by default. Clearly a merit, because it allows to use file names that are not contained in the "ANSI codepage". Nowadays users can use (type, display, manipulate) such file names in the cmd.exe windows; any program which is not on par with this ability is deficient. Gnulib still uses the "A" suffixed Windows APIs; clearly a demerit. 3) The Emacs w32.c fdutimens function handles only 1 second resolution; the Gnulib fdutimens supports sub-second resolution. 4) Different errno mapping: Filename GetLastError() errno in Emacs errno in Gnulib '\\server' ERROR_BAD_PATHNAME EINVAL ENOENT '\\server\nonexistentshare\' ERROR_BAD_NET_NAME EINVAL ENOENT ? ERROR_INVALID_DRIVE ENOENT EINVAL ? ERROR_BAD_NETPATH ENOENT EINVAL ? ERROR_DEV_NOT_EXIST ENOENT EINVAL 'C:\System Volume Information\foo' ERROR_ACCESS_DENIED EACCES EACCESS or EPERM (*) 'C:\pagefile.sys' ERROR_SHARING_VIOLATION EACCES EACCESS or EPERM (*) (*) According to POSIX: http://pubs.opengroup.org/onlinepubs/9699919799/functions/utime.html Can you tell me how to provoke a ERROR_INVALID_DRIVE, ERROR_BAD_NETPATH, or ERROR_DEV_NOT_EXIST error code? 5) Anything else? Bruno