RE: [PATCH] open bookmark in other frame

[Drew Adams <drew.adams@oracle.com>]

> > My suggestions in this regard, FWIW:
> >
> > 1. Don't use `view-buffer-other-frame'.
> >      Select the buffer, and not just read-only. Jumping to a bookmark
> >      typically puts you at its location (hence select), and the buffer is
> >      typically not put in a read-only mode. IOW, do the equivalent of
> >      this, or similar:
> >
> >      (let ((pop-up-frames  t)) (bookmark-jump-other-window bookmark)
> >
> > 2. Don't use `F' as the key binding in the bookmark-list buffer.
> >      `F' is more often used for files than for frames. Maybe use `5'.
> >
> >      (I use `J 5' in Bookmark+. `J' is a prefix for the jump commands
> >      in the bookmark-list buffer. The `5' is from `C-x 5' bindings for
> >      other-frame. I bind the command to `C-x 5 B' and `C-x j 5' globally.
> >      `C-x j' is a global prefix key for bookmark jump commands.)
> 
> So here is the new version of the patch
> 1. Use pop-up-frames variable to avoid a read-only mode on new frame.
>     I also had to use (other-frame 1) to ensure new frame is raised.

1. `pop-up-frames' has nothing to do with read-only. It just makes an "other-window" function use another frame instead of another window. If you use `bookmark-jump-other-window' instead of `bookmark-jump' then you don't need to also use `(other-frame 1)'. See the code I sent.

2. I don't think you need to include this in the doc string:

    , so the bookmark menu bookmark remains visible in its window.

That text is present for the other-window case, to emphasize that the same window is not reused. (It's not really needed there either, but it can help.) If we say that the bookmark is selected in another frame then it's pretty clear that we don't reuse the original window.

HTH.