From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jackson Ray Hamilton Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile Date: Sat, 17 Dec 2016 16:06:38 -0800 Message-ID: <357c3d56-6fe1-fcd1-8403-eaab95ab9af8@gmail.com> References: <20160805013757.31623.20092@vcs.savannah.gnu.org> <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1482031611 9499 195.159.176.226 (18 Dec 2016 03:26:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Dec 2016 03:26:51 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 Cc: emacs-devel To: Stefan Monnier , Jackson Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 18 04:26:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIS7V-0000t4-NR for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2016 04:26:41 +0100 Original-Received: from localhost ([::1]:39037 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIS7a-0007Xo-30 for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 22:26:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIP1e-0005cX-Go for emacs-devel@gnu.org; Sat, 17 Dec 2016 19:08:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIP1b-0000Yf-CE for emacs-devel@gnu.org; Sat, 17 Dec 2016 19:08:26 -0500 Original-Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:36428) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cIP1b-0000Xd-4x for emacs-devel@gnu.org; Sat, 17 Dec 2016 19:08:23 -0500 Original-Received: by mail-oi0-x244.google.com with SMTP id u15so15085333oie.3 for ; Sat, 17 Dec 2016 16:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=ERGl37MWP6VFyl6cJBYpFmUCiIJSf4z7BM4TZ2YNYdo=; b=GQiOKG/H21BPMKKulIKkwy/c79VGnQjArZ+8MUPc3dP3huK5d+SoxcaoQh77TIu5it V/bLEzREn7Zi4JSeC9BWypaOrMOu2fkD8Xk3Ptraf2u6rFT8jzYGo2nfdeGn9wMtab+S Yi/PHb30sdpyOv/xPxxwxNyiDyx51zpv41wonDR2NHKS6TE7aChaRqZE1giRtsW3eDx6 0YyczpLk5UhSHLvNyZysKT3+VvOYWuYf61Fa1GLihU6i9v4zawXEcv+f+B4VzBWWbe18 eDTxjegDZEAejllob69ejAHZVC4/LtSZJ9do68MxySobDhjy8cN8+MgV3lg6mujtnN+P /m9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=ERGl37MWP6VFyl6cJBYpFmUCiIJSf4z7BM4TZ2YNYdo=; b=M6Vy6YYsp3bjZjRtodzlyyt4P4VRV7iqnXQzw6qWtkqn0mBF/KJtq8orrBzEjapade 0As664dIN/s+wszkzRhsyrWLG6DKXz65H6eG1PnUpl8+oCZ+piH+s/vtVQSPrV2cHR+R Q9KV00FaqMpzy0nVdXP+JpHmLLPDwm8N8JoinSKy0TR73+4KDUz9MaSBaNWdw7hGQ66D jRNmJIUAluhNRlnx801bWnzbPN09dT5G140Z9Yvpl9ponxUa4xMC3a4crhyFlfBffJgi I077Tjfx9Ed4d0tdJn5rn4gzNm0NRMMA+YmOZJvT8+Vdt7PSFUqYQX1p5OJr6vQoLuH3 9Uyw== X-Gm-Message-State: AIkVDXL53W2WkGGyhVwxQdXk2yQPBoZm/oclzy51N+Ot3sW7A6DURPo59//4zL9Ovx2Mgw== X-Received: by 10.202.235.78 with SMTP id j75mr5751777oih.74.1482019700774; Sat, 17 Dec 2016 16:08:20 -0800 (PST) Original-Received: from [10.145.8.123] (99-11-22-150.lightspeed.sndgca.sbcglobal.net. [99.11.22.150]) by smtp.gmail.com with ESMTPSA id r34sm4939205otr.12.2016.12.17.16.08.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Dec 2016 16:08:20 -0800 (PST) X-Enigmail-Draft-Status: N1110 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::244 X-Mailman-Approved-At: Sat, 17 Dec 2016 22:25:30 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210596 Archived-At: Hi Stefan, I was hoping we could revisit this issue, and use .elpaignore to exclude files from byte compilation. Apparently, tar uses gnulib's excluded_file_name function, which appears to delegate to fnmatch, which looks pretty complex to me. I'm not aware of a "standalone" command providing an interface for this pattern matcher, but if one exists, maybe we could utilize that. Another option might be to generate an archive with tar and then use the list of included files to determine what to compile. This command: $ tar -ch packages/context-coloring/ --exclude-vcs -X \ packages/context-coloring/.elpaignore | tar --list Produces this output: packages/context-coloring/ packages/context-coloring/LICENSE packages/context-coloring/context-coloring-emacs-lisp.el packages/context-coloring/README.md packages/context-coloring/context-coloring-javascript.el packages/context-coloring/context-coloring.el We could filter down the ".el" files from there. Jackson On 08/06/2016 11:29 AM, Stefan Monnier wrote: >> The contents of these test fixtures are significant. Changing them caused >> the project's tests to fail. > > Hmm... indeed I see that now. > >> Can byte compilation be disabled for these >> files without modifying their source? (For instance, by disabling >> byte-compilation for the whole fixtures/ directory? Maybe through >> .dir-locals.el? Or maybe by respecting .elpaignore?) > > Respecting .elpaignore would be perfect, indeed. But that file is using > a format defined by tar, whereas I'd need to tweak the GNUmakefile rules > to understand it, which is rather tricky. > > I'll see what I can come up with. > > > Stefan > > >> On Thu, Aug 4, 2016 at 6:37 PM, Stefan Monnier >> wrote: > >>> branch: master >>> commit b7d8d3ca7f1bc279a3e8b21646ccea481c93ed46 >>> Author: Stefan Monnier >>> Commit: Stefan Monnier >>> >>> * fixtures/test/: Don't byte-compile >>> --- >>> packages/context-coloring/fixtures/test/cond.el | 1 >>> + >>> packages/context-coloring/fixtures/test/condition-case.el | 1 >>> + >>> packages/context-coloring/fixtures/test/defun.el | 1 >>> + >>> packages/context-coloring/fixtures/test/ignored.el | 1 >>> + >>> packages/context-coloring/fixtures/test/let.el | 1 >>> + >>> packages/context-coloring/fixtures/test/macroexp-let2.el | 1 >>> + >>> packages/context-coloring/fixtures/test/unbalanced-parenthesis.el | 1 >>> + >>> packages/context-coloring/fixtures/test/varlist-spacing.el | 1 >>> + >>> 8 files changed, 8 insertions(+) >>> >>> diff --git a/packages/context-coloring/fixtures/test/cond.el >>> b/packages/context-coloring/fixtures/test/cond.el >>> index d5aae5b..5ed1ec2 100644 >>> --- a/packages/context-coloring/fixtures/test/cond.el >>> +++ b/packages/context-coloring/fixtures/test/cond.el >>> @@ -1,3 +1,4 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (let (a) >>> (cond >>> (a t) >>> diff --git a/packages/context-coloring/fixtures/test/condition-case.el >>> b/packages/context-coloring/fixtures/test/condition-case.el >>> index 151f591..56a5f44 100644 >>> --- a/packages/context-coloring/fixtures/test/condition-case.el >>> +++ b/packages/context-coloring/fixtures/test/condition-case.el >>> @@ -1,3 +1,4 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (condition-case err >>> (progn err free) >>> (error err free) >>> diff --git a/packages/context-coloring/fixtures/test/defun.el >>> b/packages/context-coloring/fixtures/test/defun.el >>> index 10a52f6..173ba0b 100644 >>> --- a/packages/context-coloring/fixtures/test/defun.el >>> +++ b/packages/context-coloring/fixtures/test/defun.el >>> @@ -1,3 +1,4 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (defun abc (def ghi &optional jkl) >>> (+ def ghi jkl free)) >>> >>> diff --git a/packages/context-coloring/fixtures/test/ignored.el >>> b/packages/context-coloring/fixtures/test/ignored.el >>> index 1f5fd42..0c540ff 100644 >>> --- a/packages/context-coloring/fixtures/test/ignored.el >>> +++ b/packages/context-coloring/fixtures/test/ignored.el >>> @@ -1,2 +1,3 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (defun a () >>> (+ a 1 +1 -1 1.0 #x0 ,a :a t nil (0 . 0))) >>> diff --git a/packages/context-coloring/fixtures/test/let.el >>> b/packages/context-coloring/fixtures/test/let.el >>> index 49edb50..761a265 100644 >>> --- a/packages/context-coloring/fixtures/test/let.el >>> +++ b/packages/context-coloring/fixtures/test/let.el >>> @@ -1,3 +1,4 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (let (a >>> (b a) >>> (c free) >>> diff --git a/packages/context-coloring/fixtures/test/macroexp-let2.el >>> b/packages/context-coloring/fixtures/test/macroexp-let2.el >>> index 1b61df2..97fbb23 100644 >>> --- a/packages/context-coloring/fixtures/test/macroexp-let2.el >>> +++ b/packages/context-coloring/fixtures/test/macroexp-let2.el >>> @@ -1,3 +1,4 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (let (exp) >>> (macroexp-let2 macroexp-copyable-p v exp >>> v exp)) >>> diff --git a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >>> b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >>> index caaf7e2..e028aef 100644 >>> --- a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >>> +++ b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >>> @@ -1,2 +1,3 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (let ()) >>> (let () >>> diff --git a/packages/context-coloring/fixtures/test/varlist-spacing.el >>> b/packages/context-coloring/fixtures/test/varlist-spacing.el >>> index 97ec208..399cd18 100644 >>> --- a/packages/context-coloring/fixtures/test/varlist-spacing.el >>> +++ b/packages/context-coloring/fixtures/test/varlist-spacing.el >>> @@ -1,3 +1,4 @@ >>> +;; -*- no-byte-compile:t' -*- >>> (let ( >>> (a (lambda ())))) >>> >>>