unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Again: `find-lisp-default-directory-predicate' and symlinks
@ 2007-02-27 23:37 Stuart D. Herring
  2007-02-28  9:47 ` Kim F. Storm
  2007-02-28 17:55 ` Richard Stallman
  0 siblings, 2 replies; 3+ messages in thread
From: Stuart D. Herring @ 2007-02-27 23:37 UTC (permalink / raw)
  To: emacs-devel

$ cvs update tells me that my 1-line find-lisp.el bugfix mentioned at

http://lists.gnu.org/archive/html/emacs-devel/2006-08/msg00262.html

has never been applied, nor was it rejected in a reply email (that I saw).
 May I have it looked at again before the release?

Thanks,
Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Again: `find-lisp-default-directory-predicate' and symlinks
  2007-02-27 23:37 Again: `find-lisp-default-directory-predicate' and symlinks Stuart D. Herring
@ 2007-02-28  9:47 ` Kim F. Storm
  2007-02-28 17:55 ` Richard Stallman
  1 sibling, 0 replies; 3+ messages in thread
From: Kim F. Storm @ 2007-02-28  9:47 UTC (permalink / raw)
  To: emacs-devel

"Stuart D. Herring" <herring@lanl.gov> writes:

> $ cvs update tells me that my 1-line find-lisp.el bugfix mentioned at
>
> http://lists.gnu.org/archive/html/emacs-devel/2006-08/msg00262.html
>
> has never been applied, nor was it rejected in a reply email (that I saw).
>  May I have it looked at again before the release?

Here's the original posting:

Isn't this trivial patch needed to get
`find-lisp-default-directory-predicate' to actually detect symlinks?  (See
`find-lisp-default-file-predicate' for comparison.)  If so, please
install.

Thanks,
Davis

*** find-lisp.el.~1.13.~        2006-02-13 18:21:31.000000000 -0700
--- find-lisp.el        2006-08-07 16:52:21.000000000 -0600
***************
*** 96,102 ****
           (string= dir "..")
           ;; Skip directories which are symlinks
           ;; Easy way to circumvent recursive loops
!          (file-symlink-p dir))))

  (defun find-lisp-default-file-predicate  (file dir)
    "True if FILE matches `find-lisp-regexp'.
--- 96,102 ----
           (string= dir "..")
           ;; Skip directories which are symlinks
           ;; Easy way to circumvent recursive loops
!          (file-symlink-p (expand-file-name dir parent)))))

  (defun find-lisp-default-file-predicate  (file dir)
    "True if FILE matches `find-lisp-regexp'.



-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Again: `find-lisp-default-directory-predicate' and symlinks
  2007-02-27 23:37 Again: `find-lisp-default-directory-predicate' and symlinks Stuart D. Herring
  2007-02-28  9:47 ` Kim F. Storm
@ 2007-02-28 17:55 ` Richard Stallman
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2007-02-28 17:55 UTC (permalink / raw)
  To: herring; +Cc: emacs-devel

Re: http://lists.gnu.org/archive/html/emacs-devel/2006-08/msg00262.html

That change seems correct.  Would someone please install it,
then ack?

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-02-28 17:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-27 23:37 Again: `find-lisp-default-directory-predicate' and symlinks Stuart D. Herring
2007-02-28  9:47 ` Kim F. Storm
2007-02-28 17:55 ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).