From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Stephen Berman <stephen.berman@gmx.net>
Cc: emacs-devel@gnu.org
Subject: RE: Compilation warnings in mouse.el
Date: Tue, 12 Jul 2016 14:04:50 +0000 (UTC) [thread overview]
Message-ID: <3513ab5e-4a5e-4abe-abee-81c0a4a3cb0e@default> (raw)
In-Reply-To: <<8337nfcupy.fsf@gnu.org>>
> Unlike Stefan, I think we should add :group to every defcustom.
> Having them mysteriously missing from some of them is a time bomb:
> remove or add enough defcustoms in the same file, and you have a bug.
100% agreement. I don't even think we should have introduced this
"shortcut" or "timesaver" feature. It serves no purpose and can
lead to problems.
> Are there any downsides to having :group in all defcustoms?
Not that I can see. I'd like to see it be required, but if it's
too late for that then I'd like to see a compiler warning at least.
next parent reply other threads:[~2016-07-12 14:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<8360scdzik.fsf@gnu.org>
[not found] ` <<87zipnzvo4.fsf@gmx.net>
[not found] ` <<8337nfcupy.fsf@gnu.org>
2016-07-12 14:04 ` Drew Adams [this message]
2016-07-11 14:23 Compilation warnings in mouse.el Eli Zaretskii
2016-07-11 21:55 ` Stephen Berman
2016-07-12 5:04 ` Eli Zaretskii
2016-07-12 8:45 ` Stephen Berman
2016-07-12 22:40 ` John Wiegley
2016-07-12 22:58 ` Stefan Monnier
2016-07-13 9:28 ` Joost Kremers
2016-07-13 12:45 ` Stefan Monnier
2016-07-13 14:08 ` Drew Adams
2016-07-13 14:31 ` Eli Zaretskii
2016-07-13 15:12 ` Stefan Monnier
2016-07-13 15:22 ` Drew Adams
2016-07-13 15:37 ` Stefan Monnier
2016-07-13 16:07 ` Drew Adams
2016-07-13 15:36 ` Eli Zaretskii
2016-07-13 15:42 ` Stefan Monnier
2016-07-13 16:07 ` Drew Adams
2016-07-13 16:13 ` Eli Zaretskii
2016-07-13 16:42 ` Stefan Monnier
2016-07-12 22:56 ` Dmitry Gutov
2016-07-13 14:30 ` Eli Zaretskii
2016-07-13 14:41 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3513ab5e-4a5e-4abe-abee-81c0a4a3cb0e@default \
--to=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).