dev-tsdh-* themes

dev-tsdh-* themes

[Eli Zaretskii]

This revision on the trunk:

  revno: 102768
  committer: Tassilo Horn <tassilo@member.fsf.org>
  branch nick: trunk
  timestamp: Thu 2011-01-06 08:35:47 +0100
  message:
    * themes/dev-tsdh-light-theme.el (dev-tsdh-light): New theme.
    * themes/dev-tsdh-dark-theme.el (dev-tsdh-dark): New theme.
  added:
    etc/themes/dev-tsdh-dark-theme.el
    etc/themes/dev-tsdh-light-theme.el
  modified:
    etc/ChangeLog

introduced 2 files whose names clash on 8+3 filesystems.  Can they be
renamed by dropping the "dev-" prefix, i.e. to tsdh-dark-theme.el and
tsdh-light-theme.el, respectively?  That would resolve the issue, and
the "dev-" prefix doesn't seem to be of any importance, I think.

TIA

Re: dev-tsdh-* themes

[Tassilo Horn]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>   revno: 102768
>   committer: Tassilo Horn <tassilo@member.fsf.org>
>   branch nick: trunk
>   timestamp: Thu 2011-01-06 08:35:47 +0100
>   message:
>     * themes/dev-tsdh-light-theme.el (dev-tsdh-light): New theme.
>     * themes/dev-tsdh-dark-theme.el (dev-tsdh-dark): New theme.
>   added:
>     etc/themes/dev-tsdh-dark-theme.el
>     etc/themes/dev-tsdh-light-theme.el
>   modified:
>     etc/ChangeLog
>
> introduced 2 files whose names clash on 8+3 filesystems.  Can they be
> renamed by dropping the "dev-" prefix, i.e. to tsdh-dark-theme.el and
> tsdh-light-theme.el, respectively?

The idea was to ship some themes by emacs contributors, so I suggested
to prefix them with "dev-".  However, the theme names don't need to
match the file names, so I'm going to rename them as you suggested.

Thanks,
Tassilo

Re: dev-tsdh-* themes

[Eli Zaretskii]

> From: Tassilo Horn <tassilo@member.fsf.org>
> Cc: emacs-devel@gnu.org
> Date: Fri, 07 Jan 2011 11:35:11 +0100
> 
> The idea was to ship some themes by emacs contributors, so I suggested
> to prefix them with "dev-".  However, the theme names don't need to
> match the file names, so I'm going to rename them as you suggested.

Thank you.

Re: dev-tsdh-* themes

[Glenn Morris]

Why do all the names have a "-theme" suffix? They are in a theme/
directory, isn't that enough?

Re: dev-tsdh-* themes

[Glenn Morris]

Glenn Morris wrote:

> Why do all the names have a "-theme" suffix? They are in a theme/
> directory, isn't that enough?

Similarly, why does everything in test/ have a -testsuite suffix?

(ans: because the first file there, icalendar-testsuite.el, did)

Re: dev-tsdh-* themes

[Chad Brown]

On Jan 7, 2011, at 6:50 PM, Glenn Morris wrote:

> Why do all the names have a "-theme" suffix? They are in a theme/
> directory, isn't that enough?

The default emacs mode line indicator (the primary identifier, IMHO) does a poor job of indicating the differences between cases like these.   Start emacs -q and load up a theoretical `lisp/project.el' and it's test suite `test/project.el' -- it can be difficult to tell them apart.

I've long since adopted a different mode line format to address this problem, and list-/ibuffers addresses this somewhat, but there are still places (such as switch-to-buffer) where it crops up often enough that I'm totally unsurprised to see the information added to the file name.

Hope that helps,
*Chad

Re: dev-tsdh-* themes

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Fri, 07 Jan 2011 21:50:48 -0500
> 
> Glenn Morris wrote:
> 
> > Why do all the names have a "-theme" suffix? They are in a theme/
> > directory, isn't that enough?
> 
> Similarly, why does everything in test/ have a -testsuite suffix?

Indeed, I see no reason for this waste of real estate.

> (ans: because the first file there, icalendar-testsuite.el, did)

Probably.

Btw, if we are talking about reorganizing file names in etc/themes,
then Tassilo's problem with the dev- prefix could also be solved by
having an etc/themes/contrib/ subdirectory, which is what most
packages do these days for files contributed by people other than the
immediate maintainers.

Re: dev-tsdh-* themes

[Eli Zaretskii]

> From: Chad Brown <yandros@MIT.EDU>
> Date: Sat, 8 Jan 2011 01:25:52 -0800
> Cc: emacs-devel@gnu.org
> 
> 
> On Jan 7, 2011, at 6:50 PM, Glenn Morris wrote:
> 
> > Why do all the names have a "-theme" suffix? They are in a theme/
> > directory, isn't that enough?
> 
> The default emacs mode line indicator (the primary identifier, IMHO) does a poor job of indicating the differences between cases like these.   Start emacs -q and load up a theoretical `lisp/project.el' and it's test suite `test/project.el' -- it can be difficult to tell them apart.

There's any number of ways to solve this, for people who are annoyed
by this issue, see uniquify-buffer-name-style.  I'm sure you know
that.

Re: dev-tsdh-* themes

[Philipp Haselwarter]

Just wondering, why are the themes in etc/ instead of lisp/ ?
I didn't even know they're there until I saw this thread.


-- 
Philipp Haselwarter

Re: dev-tsdh-* themes

[Eli Zaretskii]

> From: Philipp Haselwarter <philipp.haselwarter@gmx.de>
> Date: Sat, 08 Jan 2011 11:10:52 +0100
> Tomato: Beige
> 
> Just wondering, why are the themes in etc/ instead of lisp/ ?
> I didn't even know they're there until I saw this thread.

Whenever you update from the repository, check out the latest changes
in etc/NEWS, and you will see this, for example:

  ** Custom Themes

  *** `M-x customize-themes' lists Custom themes which can be enabled.

  *** New option `custom-theme-load-path' is the load path for themes.
  Emacs no longer looks for custom themes in `load-path'.  The default
  is to search in `custom-theme-directory', followed by a built-in theme
  directory named "themes/" in `data-directory'.

Re: dev-tsdh-* themes

[Dimitri Fontaine]

Chad Brown <yandros@MIT.EDU> writes:
> I've long since adopted a different mode line format to address this
> problem, and list-/ibuffers addresses this somewhat, but there are
> still places (such as switch-to-buffer) where it crops up often enough
> that I'm totally unsurprised to see the information added to the file
> name.

I'm using projects.el from emacs-goodies-el for that, and all it's
missing would be a more automated way to define the project name of a
subtree.

  https://alioth.debian.org/scm/viewvc.php/emacs-goodies-el/elisp/emacs-goodies-el/projects.el?view=markup&revision=1.2&root=pkg-goodies-el

Regards,
-- 
dim

RE: dev-tsdh-* themes

[Drew Adams]

> could also be solved by having an etc/themes/contrib/ subdirectory,
> which is what most packages do these days for files contributed by
                                 ^^^^^^^^^^
> people other than the immediate maintainers.

So did Emacs itself have a `contrib' subdir, decades ago, for Lisp files
distributed but not maintained by Officialdom.  I don't recall whether that was
GNU Emacs, XEmacs, Epoch,... or some subset of these.

Re: dev-tsdh-* themes

[Andreas Schwab]

"Drew Adams" <drew.adams@oracle.com> writes:

> So did Emacs itself have a `contrib' subdir, decades ago

$ git log --name-only --format=%% | grep contrib/
[nothing]

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

RE: dev-tsdh-* themes

[Drew Adams]

> > So did Emacs itself have a `contrib' subdir, decades ago
           ^^^^^

> $ git log --name-only --format=%% | grep contrib/
> [nothing]

I specifically said that it might have been another Emacs from GNU Emacs.  Emacs
is not (heresy!) synonymous with GNU Emacs.  Emacs has a longer (yes) and richer
(yes) history than what you will find by grepping GNU Emacs logs.

(But thanks to you and `grep' for showing that GNU Emacs has no record of a
`contrib' subdir.)

My point was that it is not only "these days" that a `contrib' subdir is used
"for files contributed by people other than the immediate maintainers".  That
practice is nothing new.  It has a very long history, including within Emacs.

Re: dev-tsdh-* themes

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

> Why do all the names have a "-theme" suffix? They are in a theme/
> directory, isn't that enough?

They can also go in .emacs.d.

Re: dev-tsdh-* themes

[Chong Yidong]

Tassilo Horn <tassilo@member.fsf.org> writes:

> The idea was to ship some themes by emacs contributors, so I suggested
> to prefix them with "dev-".  However, the theme names don't need to
> match the file names, so I'm going to rename them as you suggested.

The theme names ought to match the file names; this is implicitly
assumed in the Custom themes code.  I renamed the themes to
tsdh-light/tsdh-dark.

Re: dev-tsdh-* themes

[Glenn Morris]

Chong Yidong wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Why do all the names have a "-theme" suffix? They are in a theme/
>> directory, isn't that enough?
>
> They can also go in .emacs.d.

They could instead go in ~/.emacs.d/theme/ ...

(This is just petty, I know.)