From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Thu, 30 Dec 2021 09:47:48 +0100 Message-ID: <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23306"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, sdsg@amazon.com To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 30 09:48:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2r79-0005tA-RT for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Dec 2021 09:48:47 +0100 Original-Received: from localhost ([::1]:38090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2r78-0004C0-K7 for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Dec 2021 03:48:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2r6K-0003Un-48 for emacs-devel@gnu.org; Thu, 30 Dec 2021 03:47:56 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:55573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2r6I-0006ui-9d; Thu, 30 Dec 2021 03:47:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640854069; bh=4Tbf59MTzUdeZLk9WFqxLH56MGkyH+d2DJmnqEYe/3Y=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=H5GkIyk7xhTrjOZg8EeTa8r+IEYAd/vBinqr3cCkZqpQ6LeLOkfuZBI6emytpS0Ib PrnQSeM5woz5U+cb06IWO1pnIEI2EjWM0nkjVzornFnm01/Owt6tJphp/W48GOOIi3 8eDWGE6hNF/3R7fZR5oQa+bompEyvlUJ8hmnDJVU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([213.142.97.158]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKbgE-1mhtw92hJM-00KxZZ; Thu, 30 Dec 2021 09:47:49 +0100 In-Reply-To: <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> Content-Language: en-US X-Provags-ID: V03:K1:PxJq3H5QMhQGtNVOD0Huew0ztgVvMGGmc4nBYibOtnASRYQBl/a pqj0I6ckxkbngz713ok54s2AQkaEG6AE+dxlMm/qLqPXtiVemLprEtYU3KLJNZf123Wgc7l 6yRmvV2uCOnp7kz7TulsWdNAbpznS+6GAGfvx7X/xIIVr1cCu0PTGeAXzlkKyA5DGuan9Yd n3m8RggUT75G+uaYjXi9g== X-UI-Out-Filterresults: notjunk:1;V03:K0:pBMXGZW+4u0=:/rELXpwoHoi3ldnikAkmt/ pols5SFXAwB3zj2cofKH2/yNEeLSadoGAJ34yd+Fmq9ws69gwucIMO6guEfnPA5Lc7llE4LC6 fh9eaXBp6MLXNH1LFNPb9fcf1kah5fdd6aqIIGsbfTtFAU0RVBE1jZn0WM7dfppHH3d7iS2+v m3FMqaWIpq+qlwR3m3kPJC03j3a9/xfDDZPyIbBmC/t1L2iTBTSZ/jyAx+YRAIsXW17HuZ9O+ AG0XEA1XevyiYeMijqEH3pW6JZ2yTbMdtlqC1EtSZoXQOiK7ElQ+IltxxfHfYTvqqfsYjeqtj BLsuex2wL0WkIQ/ro0ksOJh7toa0bkoJCuz+WXS7b4tTCV2vxxMSpfWNYsTm/zZwI9tK0dW29 aQ9KDyzzca4zsUWHnUBwClxZznFmgXfccU03qDzVHZHM0rFm+MtNOrIWGjARXWVjTRtPHaqRN 0fIeIxA/kPbgexLhOvSKMDtU62cq7uCthYgItoiTZYeYacWXAWv34Z0+T4FBH7YadegW9DAuP yyIaFfNldgIlOQNQj2AUWDDihOJgMmkFKFrSWrAqrC8EBVtLvk8sOGupP3KfNY1SNzGzTOh0+ 1oFtOKbg+lQJYlAw5MPiL3o8foMnZu2KLN3cpEQzWX66GXZzUybUTUccLVnyv5UtJ+VBAwM8f yzLbT2pJqmS7u59OU9HUx832PQn9rv20rj2/UZCM1xgT5k6ExKR9eFCMFk+LhIipypbNwx23/ fQu6G9M4AqoEHlRfC5DVhZhAGG2Dab+fUL3II3lQUA0sMGvulhulxry/yrMqn88vkB19Ee93 Received-SPF: pass client-ip=212.227.15.19; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283627 Archived-At: > Sorry, but I simply don't understand what's going on here. Sam > Steingold's original report starts with the following statement: > > I would like to request reverting of the patch > > 70b64e0d040e9c57f1a489c9ebee553264033119 "Use pop-to-buffer-same-window for shell" > > When I already have a window with shell, this patch creates a second > such window. > It seems much more reasonable to use pop-to-buffer in eshell rather than > break shell's behavior. > > If you insist on your desired behavior, please add a user variable > `shell-pop-to-buffer-action` that you would set to > `display-buffer--same-window-action`. > > Now IIUC the original code had 'pop-to-buffer' which conceptually does > create a new window. 'pop-to-buffer-same-window' OTOH conceptually > reuses the same window instead. So how that patch could provoke this > behavior > > When I already have a window with shell, this patch creates a second > such window. > > is beyond my understanding. Sorry again, I slowly start understanding now. I now think that the original patch should be reverted or that we need a general new display buffer action that preferably (1) reuses a window already showing the buffer (2) uses the same window and only then (3) uses another window. Maybe Juri has an idea. martin