From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master a154f0aa73b: shell-command-mode: New major mode for async-shell-command Date: Fri, 13 Sep 2024 01:25:01 +0300 Message-ID: <3481c86f-4556-4aea-a210-3c3cc2cc066c@gutov.dev> References: <171725425592.12207.12803647035618659064@vcs2.savannah.gnu.org> <20240601150416.5D061C5400F@vcs2.savannah.gnu.org> <87ttelkrrk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7514"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Robert Pluim , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 13 00:25:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sosGD-0001le-VT for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Sep 2024 00:25:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sosFT-0002cG-MJ; Thu, 12 Sep 2024 18:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sosFS-0002aI-OG for emacs-devel@gnu.org; Thu, 12 Sep 2024 18:25:10 -0400 Original-Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sosFR-000892-0U for emacs-devel@gnu.org; Thu, 12 Sep 2024 18:25:10 -0400 Original-Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfhigh.phl.internal (Postfix) with ESMTP id 589EB11403F3; Thu, 12 Sep 2024 18:25:06 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 12 Sep 2024 18:25:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1726179906; x=1726266306; bh=MVHatg6ZqI/DmPSF2F2H8nmncoI8OwT1TaCvfsjtztk=; b= cb+5woa6R5nQiLE50SEWBtZC3zwi66ay3P9hOvpd7CNkpwklAyEV6XaqbnNof+Jc 3ntmurPhLjCeitvq+1yXSJ31Y2NZJr2p13uQJ2AJeiCPJoWDTOIc0u5vV9X0DcYU sx9c9tRv34QFiTkGz03s4Po00IeojxgMJ73kIecCng8kyObFWCOM7hxm/ZWteZSc CGUx8JMdW2cOP82lJr/JlbCvkexzTNpp8y1t7eheq24uQWX6FGr9ViIJSbP065Zl Vez37o+r5RkcQ9FHDV93u14xC0Po5nmfMBfXtnI2KHANPCFQp5bZ60OBHneE9zw2 6WlLHMYNhQ9sEAUmbHct8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726179906; x= 1726266306; bh=MVHatg6ZqI/DmPSF2F2H8nmncoI8OwT1TaCvfsjtztk=; b=S YsFtGDYzVHwjQuQaFn8aF4YV5S5o4yq3TdcwZJhA2DYGOiGZeH8NkOyVOPaSfrmC uelgk3t4ksvt8t3ZNmSCJhQLbrfo/TcjZu4u6mNkSY4JXk20Iz9+0po/40L8/ftt w8vfUvP+jYALiAjNX5TaQvEPrOzAU5ynGUtenOL2EvlqdSCcIH1XVVH44rEC4/7i Y+ZIgiqJljRrqL77QJz19CXxTtN6ofSk7MS6/iO+pQSOXC3wdpbVRg9WeGCMmPUh eDZNSpkAP5NztibJs8Huoj7dSyJOcSPHGKkvk1OLhApmNLaE4rTggKpHIVLDvH/Z Ub71zyN/J8xxfxowErXVg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejgedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthekredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeegueegteffuddvjeevvdelleeitdeftdduhfeffeff jedukeevjedvfeffgfevgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep vddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprhhplhhuihhmsehgmhgrihhlrd gtohhmpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Sep 2024 18:25:05 -0400 (EDT) Content-Language: en-US In-Reply-To: <87ttelkrrk.fsf@gmail.com> Received-SPF: pass client-ip=103.168.172.156; envelope-from=dmitry@gutov.dev; helo=fhigh5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323569 Archived-At: On 12/09/2024 14:58, Robert Pluim wrote: > Itʼs probably too late to change for emacs-30, but any particular > reason this is a `defvar' instead of a `defcustom'? A user option implies validity of different options, but as you can see the new major mode is there to fix a bug (a long-standing one, I guess), and the defvar is for any users who feel their workflows break because of that. Not sure who would be the target audience, though.