Re: Adding git-commit highlight mode?

[Konstantin Kharlamov <Hi-Angel@yandex.ru>]

On Sun, 2025-01-05 at 02:42 +0200, Björn Bidar wrote:
> Konstantin Kharlamov <Hi-Angel@yandex.ru> writes:
> 
> > Hi, just wanted to ask this before potentially taking on the
> > initiative
> > to only find the code will get rejected.
> > 
> > I think a ballpark estimate of 90% of Git usage among CVSes in the
> > modern world is fair to assume.
> > 
> > But Emacs seems to be the only widely popular editor that still
> > doesn't
> > provide OOTB at least syntax highlight for git-commit format.
> 
> Does it do that if you use Emacs to commit? I.e. use VC?

I didn't try using VC as I don't know its functions to commit. But it's
tangentially related (I have well optimized workflow with zsh, so I
wouldn't need VC nor Magit): do you know that it has the highlight?

> > So, does
> > anyone have opposition to adding a major mode that would be bound
> > to
> > filenames like `COMMIT_EDITMSG` and others, and would provide the
> > aforementioned highlight?
> 
> The question is how would that benefit someone besides those that do
> not VC nor Magit. The mechanism of calling git commit having Emacs
> depends at least on with-editor which makes likely that the user
> would
> use magit or maybe vc (IDK).

Idk. I'm thinking here about the usecase where emacsclient is called as
an editor, which I think is popular too.

> > 
> > P.S.: to answer potential question "why not magit" — first it's not
> > OOTB experience. Second (but kinda related) it's a huge separate
> > package which takes off some startup time (and as of writing the
> > words
> > commit highlight specifically doesn't work if you defer the load¹),
> > but
> > not everyone needs full git-interaction suite in Emacs. Magit is
> > great,
> > but I personally just grown over the years a bunch of zsh functions
> > and
> > aliases that automate my Git workflow as much as possible, so I
> > don't
> > think there's much to optimize still. I just want the highlight 😊
> > And
> > I think, having it in Emacs would benefit the wider community too.
> 
> I might be that you load magit wrong since you seem to add :defer t
> to
> your configuration but also very likely use other options such as
> :bind
> which also enable deferred loading. That could mess up things.

No, I don't use :bind. I only have :init and :config sections.