From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Completion details and vertical completion format Date: Mon, 28 Nov 2022 10:42:38 +0000 Message-ID: <338f50d421e6a2ea4628@heytings.org> References: <86fse7wfgk.fsf@gnu.org> <865yf0cjx9.fsf@mail.linkov.net> <86fse3csit.fsf@gnu.org> <338f50d421efa71f81b6@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="828"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , emacs-devel To: Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 28 11:43:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozbbo-000Ac6-Cb for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Nov 2022 11:43:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozbb3-0001K6-Fq; Mon, 28 Nov 2022 05:42:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozbb1-0001Jp-ES for emacs-devel@gnu.org; Mon, 28 Nov 2022 05:42:43 -0500 Original-Received: from heytings.org ([95.142.160.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozbaz-0000lb-Qk; Mon, 28 Nov 2022 05:42:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669632159; bh=e7x0wFCDCAV122HPTYVrVocjbKdH10FGHr7QMkI0FhY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=AafWvNzhZooqET8cV29fMp9AJVvEyguvQN8OdNCX6Z20UMJ0dDEUjD3GZfOtLjMrQ iZSU2pzAbfhL8iIPpb76em1ImFAHK21Xv4UO13FAcfoCbTGN3kydx9pq5AIXWw7C4/ vpzROFJ9AH+xjhnLpkvIHW7ndTkzgnaCioJFfhzWrbUXy/JMxxYSwxv7V7r0L9lJZy 2Xcedmd/U1oXuq9LOWLxFzC0Or7hTb0ccFpngFePLTuD7Tx//3Pp4dU7Z4+y4EGNVT cNMAnurdLN7mCwrVhsdpxCZJFTQRIsJu1SJ3bJbzuz8TYZ/C8SjWghlzUQNWvXH53U 91kb09ADkXp0g== In-Reply-To: <338f50d421efa71f81b6@heytings.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300667 Archived-At: >>> Could you please explain what did you expect to see. >> >> Ideally, Emacs switches to `one-column' format automatically when >> completion candidates have long annotations and keep `vertical' for >> short or no annotations. > > Even with long annotations there can be enough room for two columns, if > the font is small enough. > > That being said, currently the options completions-detailed and > completions-format are incompatible: completions-format vertical has > either no effet (with a small enough font), or a wrong effect (the one > on your screenshots). > Arash, does the patch below fix your problem? The current code assumes "at least 2 columns", but that's wrong when completion candidates become long enough. diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 6bb0fa3ae9..5faa3c8d4e 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -2025,8 +2025,8 @@ completion--insert-strings (window (get-buffer-window (current-buffer) 0)) (wwidth (if window (1- (window-width window)) 79)) (columns (min - ;; At least 2 columns; at least 2 spaces between columns. - (max 2 (/ wwidth (+ 2 length))) + ;; At least 2 spaces between columns. + (max 1 (/ wwidth (+ 2 length))) ;; Don't allocate more columns than we can fill. ;; Windows can't show less than 3 lines anyway. (max 1 (/ (length strings) 2))))