From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Completion details and vertical completion format Date: Mon, 28 Nov 2022 12:19:44 +0000 Message-ID: <338f50d4212a2eedd291@heytings.org> References: <86fse7wfgk.fsf@gnu.org> <865yf0cjx9.fsf@mail.linkov.net> <86fse3csit.fsf@gnu.org> <338f50d421efa71f81b6@heytings.org> <338f50d421e6a2ea4628@heytings.org> <865yezuyno.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4135"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , emacs-devel To: Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 28 13:20:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozd7M-0000oc-KD for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Nov 2022 13:20:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozd75-0001HP-Lg; Mon, 28 Nov 2022 07:19:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozd6z-0001Fv-QN for emacs-devel@gnu.org; Mon, 28 Nov 2022 07:19:51 -0500 Original-Received: from heytings.org ([95.142.160.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozd6x-0000GB-GQ; Mon, 28 Nov 2022 07:19:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669637985; bh=4P+JbsVCdhvF1DlDNcldYyWgByWpiY4h+JGZSVV3smk=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=S8Ye5vEkHMcQKcdbcJ8q2pgddE/hm+1sEZw/ze3pj1xk7vcSxSafD27fvr6eVOXCw o+cBwVzbdmbZPx7Pu2bhKLHNlFqT/Uw89zuoF+lmDJXNGvLkI1oXCveh3q6+6ENvEy 1llABtrE89IXYpCLcTRaTXOHm9UjhRvEmrff3dmnc3e+hII+1H2tu/NQoa/DDKXIPt phAI8GeIfXrG97mXbnSKFVyG46T4BnPDOonWvGuASr3hW938a9y9Fm+WpRVFyR8YhO tDi8gLQMBf5FEwnYEiFrfOb65p5TqVSUdN6/5PYp+ZXphJXiRYy6/orRLA8XYz7K3Q MhRY/aPclGzlg== In-Reply-To: <865yezuyno.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300672 Archived-At: >> Arash, does the patch below fix your problem? The current code assumes >> "at least 2 columns", but that's wrong when completion candidates >> become long enough. > > Thanks for looking at this. Your patch fixes the issue here, I've tried > it with different use cases I have, also with the external package > 'marginalia', and it works. > Thanks for checking. Now fixed on master.