From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Extend gdb to filter registers Date: Sat, 18 Jan 2020 15:10:28 -0500 Message-ID: <33515533-17C1-48B4-9C61-3275DE7A7F54@gmail.com> References: <878spmuerf.fsf@mail.linkov.net> <83wod3bx8i.fsf@gnu.org> <9f5ddaa5-0234-a17b-bdd7-81d70a0a50d6@gmx.at> <83FFF194-64CD-409E-8B7A-5A9DF91E79DE@gmail.com> <83v9pb314t.fsf@gnu.org> <838sm510d6.fsf@gnu.org> <83muakzoy5.fsf@gnu.org> <71042c9f-478b-47c8-f27e-1348e9f4536d@gmx.at> <83iml8zkbm.fsf@gnu.org> <81EDE05A-43FA-4A1C-8C75-77CE541AD733@gmail.com> <83ftgczjmg.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_21125AEB-B12C-4466-B886-69B9138F0A89" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="29745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , juri@linkov.net, emacs-devel@gnu.org, monnier@iro.umontreal.ca, john@yates-sheets.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 18 21:11:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isuR1-0007eg-Sl for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jan 2020 21:11:07 +0100 Original-Received: from localhost ([::1]:44588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isuR0-000139-Tc for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jan 2020 15:11:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55049) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isuQV-0000cQ-3d for emacs-devel@gnu.org; Sat, 18 Jan 2020 15:10:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isuQU-0004O4-3h for emacs-devel@gnu.org; Sat, 18 Jan 2020 15:10:34 -0500 Original-Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:43055) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isuQS-0004LD-FM; Sat, 18 Jan 2020 15:10:32 -0500 Original-Received: by mail-qk1-x735.google.com with SMTP id t129so26277504qke.10; Sat, 18 Jan 2020 12:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=9laUpmn0TSGPFXJXUtPtgYlQopWwG2FGYfmpfwpZUC4=; b=lNeKI2K7VmvpzipkjeQ+W2u30PPbnkUJXKduFCTUt7mopJv1TQoqyMYNJwtNSizJJs j+dL1YdmhZsmhVj2a1uzdE4QbUHgdEuGNiu3xpBQFDAo9OOHWANhwTuESPBdisRe3bKd 0Ansqdh/foOcn1IfsyJxGsP1ZPvAoVurTTl1rTUcGg+dQkMBlYspmgyphjnwZ+LnB+Sr Hp6ExrXOzzy6LbnDjfbx8dTrIFgIXSQYbHXSAM88qaogtlYRBmjxNUQ5Gc6bF1NYhzjh zz/Zt5EDAFBJFaj1t9dZh3dSU6pPog364GFczkPJjAede/jiya9ZLN5thsO4zZ7PBSG1 u+bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=9laUpmn0TSGPFXJXUtPtgYlQopWwG2FGYfmpfwpZUC4=; b=jnWJypIA58kL0jRXPOSAcLjs2DKG/ylw0vJVWV8d03uy+HB6pQrAx2WA468pAvaVVa mLPBLPoFzXCyYiw7zqiwy+cCrxN6XK/y+iJsRjYMK332NLYCgrUlS4nnQo5T0MOVI8cW 0cv7OB8k7lVkeSqH42LtPFDROaT68dsMkwtFIgZOwheWuDwxA2X9/fBHVV2iQ92Rcx+Q niudfcVaFi8kJwg8P/71d1mg5Wr0jzf788CYgmU2ECoa66PwZ72xcxa4EiZ26CVyd/r2 zOQW0LejkjN5fgnc6H8CefXwYaGJHhEAs6ioOiHc6FCV+aj8v1JiLPWBrFzI7ytvscFH wxHw== X-Gm-Message-State: APjAAAUIcjdB03bGMpDS3eEHbeb2Dvce7aT4ToaSrwT+Yicrvjbb2f51 9XXX7rKqpRNszUBqMglGuKa6DJ064RAl24og X-Google-Smtp-Source: APXvYqwI12omfp0onS0CdGEdx1Hmg8Mj3ldhINoOF0pJkSha6MJzaQGok1yppisGvEnVG/aOoOP5Ow== X-Received: by 2002:a37:5b41:: with SMTP id p62mr44674260qkb.442.1579378230055; Sat, 18 Jan 2020 12:10:30 -0800 (PST) Original-Received: from [192.168.1.5] (c-174-60-229-153.hsd1.pa.comcast.net. [174.60.229.153]) by smtp.gmail.com with ESMTPSA id a144sm13878336qkc.30.2020.01.18.12.10.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Jan 2020 12:10:29 -0800 (PST) In-Reply-To: <83ftgczjmg.fsf@gnu.org> X-Mailer: Apple Mail (2.3608.40.2.2.4) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::735 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244356 Archived-At: --Apple-Mail=_21125AEB-B12C-4466-B886-69B9138F0A89 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > If the problem is in gud.el, then we must think about the other users > of that code, like "M-x gud-gdb". gdb-display-source-buffer is > specific to gdb-mi.el. And I see that as part of your patch you've > removed the test of gud-minor-mode being gdbmi, which is probably not > TRT. Fixed, please see source-window.patch. > Also, what happens if the function into which you step is already > displayed in some other window? Maybe we can modify `gdb-display-source-buffer` to handle that. But = I=E2=80=99m not sure if that won=E2=80=99t interfere with other stuff. = What do you think? Yuan --Apple-Mail=_21125AEB-B12C-4466-B886-69B9138F0A89 Content-Disposition: attachment; filename=source-window.patch Content-Type: application/octet-stream; x-unix-mode=0700; name="source-window.patch" Content-Transfer-Encoding: quoted-printable =46rom=20fb77ae530a8ed4eb3c9485e4bb6d60fa77dc4e3d=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Yuan=20Fu=20=0ADate:=20Sat,=20= 18=20Jan=202020=2013:58:17=20-0500=0ASubject:=20[PATCH]=20Fix=20gdb-mi=20= opens=20new=20window=20to=20display=20source=20file=0AMIME-Version:=20= 1.0=0AContent-Type:=20text/plain;=20charset=3DUTF-8=0A= Content-Transfer-Encoding:=208bit=0A=0ABy=20design=20it=20shouldn=E2=80=99= t,=20the=20problem=20is=20gud-display-line=20uses=0Adisplay-buffer=20= instead=20of=20gdb-display-source-buffer.=0A=0A*=20lisp/progmodes/gud.el=20= (gud-display-line):=20use=0Agdb-display-source-buffer=20when=20running=20= gdb-mi=0A---=0A=20lisp/progmodes/gud.el=20|=202=20++=0A=201=20file=20= changed,=202=20insertions(+)=0A=0Adiff=20--git=20a/lisp/progmodes/gud.el=20= b/lisp/progmodes/gud.el=0Aindex=20d5fd1dce6f..a81b8996cf=20100644=0A---=20= a/lisp/progmodes/gud.el=0A+++=20b/lisp/progmodes/gud.el=0A@@=20-2829,6=20= +2829,8=20@@=20gud-display-line=0A=20=09=20=20=20=20(gud-find-file=20= true-file)))=0A=20=09=20(window=20(and=20buffer=0A=20=09=09=20=20=20=20=20= =20(or=20(get-buffer-window=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(eq=20= gud-minor-mode=20'gdbmi)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(gdb-display-source-buffer=20= buffer))=0A=20=09=09=09=20=20(display-buffer=20buffer=20'(nil=20= (inhibit-same-window=20.=20t))))))=0A=20=09=20(pos))=0A=20=20=20=20=20= (when=20buffer=0A--=20=0A2.24.1=0A=0A= --Apple-Mail=_21125AEB-B12C-4466-B886-69B9138F0A89--