unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Mendler <mail@daniel-mendler.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [elpa] externals/corfu 6572247 3/4: Bind [tab] and [return]
Date: Sun, 27 Jun 2021 11:11:06 +0200	[thread overview]
Message-ID: <3209a500-8654-2508-3b1a-34a73edc0053@daniel-mendler.de> (raw)
In-Reply-To: <jwvo8bspw03.fsf-monnier+emacs@gnu.org>

On 6/26/21 4:02 PM, Stefan Monnier wrote:
>> +    (define-key map [tab] #'corfu-complete)
> 
> Please avoid binding `tab`: the `tab` event (only generated under GUIs)
> is supposed to be remapped to the TAB char-event (aka `C-i`) and this is
> what you should bind to if you want your binding to work both under ttys
> and GUIs.
> 
> More importantly, if you bind to `tab` than this binding will take
> precedence over all other bindings to TAB, even those in keymaps that
> have higher precedence.
> 
> The same holds for `return` vs RET, and `escape` vs ESC.

Hello Stefan,

I am aware of the unfortunate implications of these bindings.
Originally I avoided these bindings for the exact reasons you mention
and I hoped I could do without those (only binding RET/TAB and
remappings). However I have to use these keys since Org-mode seems to
override these keys too. Otherwise my keymap will not take precedence
over the Org-mode keymap.

Daniel



  reply	other threads:[~2021-06-27  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210626095705.11804.96621@vcs0.savannah.gnu.org>
     [not found] ` <20210626095707.B514720D0A@vcs0.savannah.gnu.org>
2021-06-26 14:02   ` [elpa] externals/corfu 6572247 3/4: Bind [tab] and [return] Stefan Monnier
2021-06-27  9:11     ` Daniel Mendler [this message]
2021-06-27 14:15       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3209a500-8654-2508-3b1a-34a73edc0053@daniel-mendler.de \
    --to=mail@daniel-mendler.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).