From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Gerry Agbobada" Newsgroups: gmane.emacs.devel Subject: Re: solarized Date: Tue, 15 Sep 2020 16:05:37 +0200 Message-ID: <31d12210-1b36-4306-8f79-43f6b4549a9d@www.fastmail.com> References: <87mu1ra1ej.fsf@protesilaos.com> <87imcf9wfp.fsf@protesilaos.com> <986EE32C-55D8-4A39-B556-872A5F49448E@thornhill.no> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f082b6c2f86847f4bc8520661e0a474b Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21541"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.3.0-259-g88fbbfa-fm-20200903.003-g88fbbfa3 To: "Gregory Heytings via Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 15 16:06:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIBbW-0005Sz-QQ for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 16:06:42 +0200 Original-Received: from localhost ([::1]:42810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIBbV-0007ei-S1 for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 10:06:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIBaV-0006jC-6A for emacs-devel@gnu.org; Tue, 15 Sep 2020 10:05:39 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:50737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIBaS-00074V-Lp for emacs-devel@gnu.org; Tue, 15 Sep 2020 10:05:38 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 99A5CA6F for ; Tue, 15 Sep 2020 10:05:33 -0400 (EDT) Original-Received: from imap9 ([10.202.2.59]) by compute2.internal (MEProxy); Tue, 15 Sep 2020 10:05:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gagbo.net; h= mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type; s=fm2; bh=uDoXGpbdw6e1VpguNWS6l/J9GJ5kxDd XgLa1kdPsnfs=; b=RMiCziJsgACntMHRv/X6iCIoEg0SFHbHetV7l/rWVodNQ7X +AoqkLbzo0hIklXINylpcPoiKoV325XyPZSN2j2PBgMg15qQC9PuKlvBzTkP3+g4 uum+0PuYcZpGxLEjB8Bl+TXWgxOVpPstu7ECcJGzWVnLCOX4izVSWkURCoF4XSWF KO7bPqLYk2VN3VIBlb8KAYWlMHurda/LlNnkS0mm8ZQwsDbwjl+dJfQnh6aaaShp lsahogKqTKCpiC0Vv/DJpmk2fkR8jvsW4hbD4sPfWuus1tBQUYAUZbyf9x5QXPwj IvnYM6dPVEWQ/PVTrWgdhGlobUzIfD0boiAsziA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uDoXGp bdw6e1VpguNWS6l/J9GJ5kxDdXgLa1kdPsnfs=; b=ILwhHt5KQclslRIVLGim7J R/EZzGFA2CvyUTcf7r2ROWv8dNDJVcxAZ+uxADDxq5YHvtLt0K17YxHcgLtAQt1o d2sIVUmVH551wf+WZ+UhhkrORmapakSHBIT+GO7IebeXpKvrSiEYYX9GxDz/+al8 qEWkEdEcwt9Y63Oe1KbjFv0jBU97y0qOH1Bf7OwAAMLcHmnvuX/Fte3C+PW2rKJT iyfhDu2j7njWVwDnZtWgaCYCxKrTpGAsdnF6d8yaXsHUUlNDAl3NL00mg/6YfgvY x5Gc3YCFCZu+gsOoO9/KZt1I+kq5oSImOUSanhXZbrkduzuRQplmVYmBA576Q1mA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtddtgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsegrtderreerredtnecuhfhrohhmpedfifgvrhhr hicutehgsghosggruggrfdcuoegvmhgrtghsqdguvghvvghlsehgrghgsghordhnvghtqe enucggtffrrghtthgvrhhnpedtkedvleehhedtueelvdefkeejvdejhfekhefgiefhjeeh veeiiefhudfghfduhfenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepvghmrggtshdquggvvhgv lhesghgrghgsohdrnhgvth X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 96E581C0256; Tue, 15 Sep 2020 10:05:32 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <986EE32C-55D8-4A39-B556-872A5F49448E@thornhill.no> Received-SPF: pass client-ip=64.147.123.21; envelope-from=emacs-devel@gagbo.net; helo=wout5-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 10:05:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255742 Archived-At: --f082b6c2f86847f4bc8520661e0a474b Content-Type: text/plain Hello, This is what theme generator plugins try to do : provide default faces and an API that allows users to define a theme by only specifying a set of colors and a set of overrides (if you want function-related faces to be "accent3" instead of "accent1"). Henrik tried to do it with emacs-doom-themes ( https://github.com/hlissner/emacs-doom-themes ) but apparently the theme generation part is not really good and he has been trying to find time to rewrite that part. But using that API to define a theme seems really easy : https://github.com/hlissner/emacs-doom-themes/blob/master/themes/doom-one-theme.el I think this is the kind of helpers that would warrant upstream integration : - Upstream can handle changes in https://github.com/hlissner/emacs-doom-themes/blob/master/doom-themes-base.el default faces and the theme generation macro [1] - theme writers or others end users just manage their color palette and the few faces they want to override [1] : https://github.com/hlissner/emacs-doom-themes/blob/d6ee47dc8ed2cf9e585f62243214af03ba5b1687/doom-themes.el#L395 On Tue, Sep 15, 2020, at 15:39, Theodor Thornhill wrote: > > > On September 15, 2020 12:16:42 PM GMT+02:00, Protesilaos Stavrou wrote: > > >The 16-colour palette that has to work on both light and dark > >backgrounds is a constraint that Emacs' defface can circumvent. An > >excerpt from 'M-x find-library faces': > > > >(defface link > > '((((class color) (min-colors 88) (background light)) > > :foreground "RoyalBlue3" :underline t) > > (((class color) (background light)) > > :foreground "blue" :underline t) > > (((class color) (min-colors 88) (background dark)) > > :foreground "cyan1" :underline t) > > (((class color) (background dark)) > > :foreground "cyan" :underline t) > > (t :inherit underline)) > > "Basic face for unvisited links." > > :group 'basic-faces > > :version "22.1") > > > >If one really wants to keep it to 16 colours, then maintain two sets of > >them. One for dark, another for light. And keep accessibility in mind. > > > > > > > Could it be an idea to generalize the modus themes? They seem very comprehensive > > Theodor Thornhill > > Gerry Agbobada --f082b6c2f86847f4bc8520661e0a474b Content-Type: text/html Content-Transfer-Encoding: quoted-printable
Hello,
=
This is what theme generator plugins try to do : provide default fac= es and an API that allows users to define a theme by only specifying a s= et of colors and a set of overrides (if you want function-related faces = to be "accent3" instead of "accent1").

Henrik tried to do it with emacs-doom-themes ( https://github.com/hlissner/emacs= -doom-themes ) but apparently the theme generation part is not reall= y good and he has been trying to find time to rewrite that part. But usi= ng that API to define a theme seems really easy : https://github.com/hlissner/emacs-doom-themes/blob/master/themes/doom-o= ne-theme.el

I think this is the kind o= f helpers that would warrant upstream integration :
- Upst= ream can handle changes in
https://github.co= m/hlissner/emacs-doom-themes/blob/master/doom-themes-base.el default= faces and the theme generation macro [1]
- theme writers or others e= nd users just manage their color palette and the few faces they want to = override

[1] :
https://github.com/hlissner/emacs-doom-themes/blo= b/d6ee47dc8ed2cf9e585f62243214af03ba5b1687/doom-themes.el#L395

On Tue, Sep 15, 2020, at 15:39, Theod= or Thornhill wrote:


On September 15, 2020 12:16:42 PM = GMT+02:00, Protesilaos Stavrou <info@protesilaos.com> wrote:

>= The 16-colour palette that has to work on both light and dark
<= div>>backgrounds is a constraint that Emacs' defface can circumvent.&= nbsp; An
>excerpt from 'M-x find-library faces':
>
>(defface link
>  '(= (((class color) (min-colors 88) (background light))
>&n= bsp;    :foreground "RoyalBlue3" :underline t)
<= div>>    (((class color) (background light))
=
>     :foreground "blue" :underline t)
>    (((class color) (min-colors 88) (backgro= und dark))
>     :foreground "cyan1= " :underline t)
>    (((class color) (ba= ckground dark))
>     :foreground "= cyan" :underline t)
>    (t :inherit und= erline))
>  "Basic face for unvisited links."
<= /div>
>  :group 'basic-faces
>  :versi= on "22.1")
>
>If one really wants to k= eep it to 16 colours, then maintain two sets of
>them.&= nbsp; One for dark, another for light.  And keep accessibility in m= ind.
>
>

=
Could it be an idea to generalize the modus themes? They = seem very comprehensive

Theodor Thornhill



Gerry Agbobada

--f082b6c2f86847f4bc8520661e0a474b--