From: "Gerry Agbobada" <emacs-devel@gagbo.net>
To: "Gregory Heytings via Emacs development discussions."
<emacs-devel@gnu.org>
Subject: Re: solarized
Date: Tue, 15 Sep 2020 16:05:37 +0200 [thread overview]
Message-ID: <31d12210-1b36-4306-8f79-43f6b4549a9d@www.fastmail.com> (raw)
In-Reply-To: <986EE32C-55D8-4A39-B556-872A5F49448E@thornhill.no>
[-- Attachment #1: Type: text/plain, Size: 2232 bytes --]
Hello,
This is what theme generator plugins try to do : provide default faces and an API that allows users to define a theme by only specifying a set of colors and a set of overrides (if you want function-related faces to be "accent3" instead of "accent1").
Henrik tried to do it with emacs-doom-themes ( https://github.com/hlissner/emacs-doom-themes ) but apparently the theme generation part is not really good and he has been trying to find time to rewrite that part. But using that API to define a theme seems really easy : https://github.com/hlissner/emacs-doom-themes/blob/master/themes/doom-one-theme.el
I think this is the kind of helpers that would warrant upstream integration :
- Upstream can handle changes in
https://github.com/hlissner/emacs-doom-themes/blob/master/doom-themes-base.el default faces and the theme generation macro [1]
- theme writers or others end users just manage their color palette and the few faces they want to override
[1] :
https://github.com/hlissner/emacs-doom-themes/blob/d6ee47dc8ed2cf9e585f62243214af03ba5b1687/doom-themes.el#L395
On Tue, Sep 15, 2020, at 15:39, Theodor Thornhill wrote:
>
>
> On September 15, 2020 12:16:42 PM GMT+02:00, Protesilaos Stavrou <info@protesilaos.com> wrote:
>
> >The 16-colour palette that has to work on both light and dark
> >backgrounds is a constraint that Emacs' defface can circumvent. An
> >excerpt from 'M-x find-library faces':
> >
> >(defface link
> > '((((class color) (min-colors 88) (background light))
> > :foreground "RoyalBlue3" :underline t)
> > (((class color) (background light))
> > :foreground "blue" :underline t)
> > (((class color) (min-colors 88) (background dark))
> > :foreground "cyan1" :underline t)
> > (((class color) (background dark))
> > :foreground "cyan" :underline t)
> > (t :inherit underline))
> > "Basic face for unvisited links."
> > :group 'basic-faces
> > :version "22.1")
> >
> >If one really wants to keep it to 16 colours, then maintain two sets of
> >them. One for dark, another for light. And keep accessibility in mind.
> >
> >
>
>
> Could it be an idea to generalize the modus themes? They seem very comprehensive
>
> Theodor Thornhill
>
>
Gerry Agbobada
[-- Attachment #2: Type: text/html, Size: 3736 bytes --]
next prev parent reply other threads:[~2020-09-15 14:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 3:48 solarized Richard Stallman
2020-09-15 8:29 ` solarized Protesilaos Stavrou
2020-09-15 9:14 ` solarized Yuri Khan
2020-09-15 10:16 ` solarized Protesilaos Stavrou
2020-09-15 13:39 ` solarized Theodor Thornhill
2020-09-15 14:05 ` Gerry Agbobada [this message]
2020-09-15 14:40 ` Theme generator (was: solarized) Stefan Monnier
2020-09-15 16:26 ` Theme generator Arthur Miller
2020-09-15 20:14 ` Stefan Monnier
2020-09-15 20:35 ` Stefan Monnier
2020-09-15 20:44 ` Arthur Miller
2020-09-16 1:49 ` Theme generator (was: solarized) Tim Cross
2020-09-17 0:25 ` chad
2020-09-17 14:25 ` Theme generator Arthur Miller
2020-09-16 5:03 ` Theme generator (was: solarized) Richard Stallman
2020-09-15 20:28 ` solarized Protesilaos Stavrou
2020-09-15 20:50 ` solarized Praharsh Suryadevara
2020-09-16 5:05 ` solarized Richard Stallman
2020-09-16 8:27 ` solarized Protesilaos Stavrou
2020-09-16 13:38 ` solarized Arthur Miller
2020-09-17 3:57 ` solarized Richard Stallman
2020-09-17 7:53 ` solarized Gian Uberto Lauri
2020-09-17 15:56 ` solarized Drew Adams
2020-09-18 4:08 ` solarized Richard Stallman
2020-09-18 4:08 ` solarized Richard Stallman
2020-09-18 16:44 ` solarized Drew Adams
2020-09-17 14:11 ` solarized Arthur Miller
2020-09-17 23:39 ` solarized Tim Cross
2020-09-18 4:13 ` solarized Richard Stallman
2020-09-18 5:49 ` solarized Tim Cross
2020-09-18 6:43 ` solarized Arthur Miller
2020-09-16 13:06 ` solarized Arthur Miller
2020-09-17 3:53 ` solarized Richard Stallman
2020-09-15 11:26 ` solarized Göktuğ Kayaalp
2020-09-15 12:15 ` solarized Elias Mårtenson
2020-09-15 12:56 ` solarized Göktuğ Kayaalp
2020-09-16 1:30 ` solarized Tim Cross
2020-09-16 10:21 ` solarized Göktuğ Kayaalp
2020-09-16 12:53 ` solarized Arthur Miller
2020-09-16 22:09 ` solarized Tim Cross
2020-09-17 14:29 ` solarized Arthur Miller
2020-09-18 13:32 ` solarized Stefan Kangas
2020-09-18 15:53 ` solarized Arthur Miller
2020-09-18 16:03 ` solarized Arthur Miller
2020-09-19 4:00 ` solarized Richard Stallman
2020-09-20 20:18 ` solarized Bozhidar Batsov
2020-09-15 12:05 ` WCAG AAA and Emacs themes Dmitry Gutov
2020-09-15 20:22 ` Protesilaos Stavrou
-- strict thread matches above, loose matches on Subject: below --
2020-09-16 18:07 solarized Protesilaos Stavrou
2020-09-17 14:55 ` solarized Arthur Miller
2020-09-17 15:27 ` solarized Arthur Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31d12210-1b36-4306-8f79-43f6b4549a9d@www.fastmail.com \
--to=emacs-devel@gagbo.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).