From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Sun, 17 Oct 2021 19:32:26 +0000 Message-ID: <31b2f1e94178d73e5f05@heytings.org> References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <834k9km5no.fsf@gnu.org> <83k0iflsze.fsf@gnu.org> <874k9jzu7a.fsf@gnus.org> <874k9juy0r.fsf@gnus.org> <87mtnbtimj.fsf@gnus.org> <87wnmd13ny.fsf@gnus.org> <87sfx10xs6.fsf@gnus.org> <87h7dfpjn3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39017"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 17 21:33:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcBuw-0009xU-Ko for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 21:33:58 +0200 Original-Received: from localhost ([::1]:59110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcBuu-0005xG-Ov for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 15:33:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcBtb-0005AJ-3J for emacs-devel@gnu.org; Sun, 17 Oct 2021 15:32:35 -0400 Original-Received: from heytings.org ([95.142.160.155]:55520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcBtX-0001Hi-HF for emacs-devel@gnu.org; Sun, 17 Oct 2021 15:32:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1634499147; bh=TxtXS6iifeagKlPgHBpFaqA4R0pk1TLCG1S+Dj8ZspU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=a8GKRUW3JjtuUxsoDZ6AzdnvnGw7BDM6XvYVlQkrqyTF1vEPBcMntpYopp4uFDxQr UR40mSajpFrjjOAiA4Q3M1KOYKuF25SBDOGTyZaStk51lmt1namHcwxULEtFFB26/I Z5ujzuvWx/6DtaJWMSCY57u5ePJcHW6My+Q5d/FUWi1Ol/nrz8yEnShnh2zG2XfwO7 JXpov4QeoaSm0BTD1faejrDbyTOuMI4BRF5lNOyn2nZsmhx/JSZ41uppATDWG/4A12 AsAK+zcdkLx4U6X11TsHpuOgNjq5XVsXT1TlDKEoNq83s1ffiwdfHTdAqBq8CIbU3C rn/sYaMS1xUcA== In-Reply-To: <87h7dfpjn3.fsf@gnus.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277229 Archived-At: > > I went with the > > ["C-c C-c"] > > syntax, and changes are now pushed to the trunk. > I still believe that using strings would have been better, but okay, "the ship has sailed". A suggestion: (kbd-valid-p "") (kbd-valid-p "") should return t, and (kbd-valid-p "<123>") should (I think) return nil. IOW, kbd-valid-p should use: (string-match-p "\\`<[A-Za-z][A-Za-z0-9_-]*>\\'" key)