clipboard-kill-ring-save with tmm: avoid when region inactive?

clipboard-kill-ring-save with tmm: avoid when region inactive?

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]

Hi,

Would the change outlined below (see user message quoted) be reasonable?

When transient-mark-mode is on, we should require the region to be active in order to copy/kill it via the commands.
I did not find any programmatic use of these commands in Emacs code, though one would wonder if this creates package incompatibilities.

- DR


diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index cd1a4d0..e6d3b12c 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -536,14 +536,18 @@
 (defun clipboard-kill-ring-save (beg end &optional region)
   "Copy region to kill ring, and save in the GUI's clipboard."
   (interactive "r\np")
-  (let ((gui-select-enable-clipboard t))
-    (kill-ring-save beg end region)))
+  (if (or (not transient-mark-mode) (use-region-p))
+      (let ((gui-select-enable-clipboard t))
+	(kill-ring-save beg end region))
+    (error "Region not active.")))
 
 (defun clipboard-kill-region (beg end &optional region)
   "Kill the region, and save it in the GUI's clipboard."
   (interactive "r\np")
-  (let ((gui-select-enable-clipboard t))
-    (kill-region beg end region)))
+  (if (or (not transient-mark-mode) (use-region-p))
+      (let ((gui-select-enable-clipboard t))
+	(kill-region beg end region))
+    (error "Region not active.")))
 
 (defun menu-bar-enable-clipboard ()
   "Make CUT, PASTE and COPY (keys and menu bar items) use the clipboard.






> Begin forwarded message:
> 
> From: Dagnat Fabien <fabien.dagnat@telecom-bretagne.eu>
> Date: February 10, 2015 at 3:33:38 AM EST
> To: Emacs on Mac OS X Mailing List <macosx-emacs@email.esm.psu.edu>
> Subject: [OS X Emacs] Old behavior of copy
> Reply-To: Emacs on Mac OS X Mailing List <macosx-emacs@email.esm.psu.edu>
> 
> Hello,
> I do not remember exactly when it changed but the behavior of "copy" changed recently. Before, if nothing was selected copy would do nothing now it copy something (don’t know exactly what) form the context of the prompt. Is there any variable to get back the old behavior? Often I mistake cmd-C for cmd-V and loose the content of the clipboard…
> 
> Fabien
> 


[-- Attachment #2: Type: text/html, Size: 6003 bytes --]