From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Christopher M. Miles" Newsgroups: gmane.emacs.orgmode,gmane.emacs.devel Subject: [CLOSED] text-property displayed image has a center-line when the text face has underline attribute Date: Sun, 02 Oct 2022 18:45:41 +0800 Message-ID: <31937.0118247875$1664708150@news.gmane.org> References: <6337ac4e.050a0220.c05b9.7747SMTPIN_ADDED_BROKEN@mx.google.com> <87r0zs14ur.fsf@localhost> <63380111.050a0220.592f2.fab7SMTPIN_ADDED_BROKEN@mx.google.com> <87o7uvsuid.fsf@localhost> <63383737.050a0220.63781.8825SMTPIN_ADDED_BROKEN@mx.google.com> <87mtae2718.fsf@localhost> <83a66eaczp.fsf@gnu.org> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19651"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.9; emacs 29.0.50 Cc: numbchild@gmail.com, yantar92@gmail.com, emacs-devel@gnu.org, emacs-orgmode@gnu.org To: Eli Zaretskii Original-X-From: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sun Oct 02 12:55:44 2022 Return-path: Envelope-to: geo-emacs-orgmode@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oewdL-0004yM-Rd for geo-emacs-orgmode@m.gmane-mx.org; Sun, 02 Oct 2022 12:55:43 +0200 Original-Received: from localhost ([::1]:47706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oewdK-0003SO-HJ for geo-emacs-orgmode@m.gmane-mx.org; Sun, 02 Oct 2022 06:55:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oewZL-0001uZ-Gz; Sun, 02 Oct 2022 06:51:36 -0400 Original-Received: from [2409:8a28:603a:44b0:52d2:f5ff:fe16:c591] (port=56005 helo=Mac-mini.local) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oewZK-0005Kb-8Y; Sun, 02 Oct 2022 06:51:35 -0400 Original-Received: by Mac-mini.local (Postfix, from userid 501) id 773E06694909; Sun, 2 Oct 2022 18:51:20 +0800 (CST) In-reply-to: <83a66eaczp.fsf@gnu.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:8a28:603a:44b0:52d2:f5ff:fe16:c591 (deferred) Received-SPF: softfail client-ip=2409:8a28:603a:44b0:52d2:f5ff:fe16:c591; envelope-from=numbchild@gmail.com; helo=Mac-mini.local X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-orgmode" Xref: news.gmane.io gmane.emacs.orgmode:149017 gmane.emacs.devel:296593 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I hate to rewrite those steps more than 3 times. But I also know Emacs contributors should not be forced to fix bug for me. Also I can't fix this bug by myself. So I think it's not a bug, I can tolerate this center line. Maybe I mastered skill for modify code in Emacs, I might come back to fix this bug by myself. But now, let me close it. I'm not hating anybody, just hate this process. Thanks for checking out. Eli Zaretskii writes: >> From: "Christopher M. Miles" >> Cc: "Christopher M. Miles" , Org Mode >> >> Date: Sun, 02 Oct 2022 15:03:26 +0800 >>=20 >> Ihor Radchenko writes: >>=20 >> > "Christopher M. Miles" writes: >> > >> >> I replaced step 5 with step 6 by extracting the logic code of >> >> org-link-beautify, but I found it does not have center-line. That's >> >> really weird. >> >> ... >> >> (put-text-property >> >> start end >> >> 'display (create-image "~/Downloads/.thumbnails/3veEPJrQrV1Et= pH9.png" nil nil :ascent 'center :max-height 512)) >> >> (make-local-variable 'image-map) >> >> (define-key image-map (kbd "") 'org-open-at-point)) >> >> #+end_src >> > >> > On my side, the put-text-property does have center-line. >> > But only when buffer is in Org mode. >> > Yet, it is not Org's fault. >> > >> > The reason you are seeing the horizontal line is org-link face. >> > org-link has underline. And the "center" line you are seeing is actual= ly >> > underline coming from the face. I'd say it is emacs bug. >>=20 >> Thanks very much for figuring out this issue, Ihor. >>=20 >> I see, I originally post this issue on Emacs-help mailing list, Eli let >> me forward this thread to Org mode mailing list. Now I need to forward >> to Emacs-devel mailing list. >>=20 >> In case the background info is missing, link original message here: >>=20 >> https://list.orgmode.org/87mtae2718.fsf@localhost/T/#m35d40f37fdf80f413d= db8d40e3017a6f102651e9 > > Please report this as a bug, with "M-x report-emacs-bug", and please > include there all the details, including the recipe to reproduce the > issue. > > Thanks. =2D-=20 [ stardiviner ] I try to make every word tell the meaning that I want to express without mi= sunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAmM5bSQACgkQG13xyVro msOdjQf+OEiyoPEBCF5t6rUW4ABBLfgbnGgWF6KSHUaw0jdAE2c/zTHc45npqpcP okXjWwlGsFwfcJxIz6NrtJAUf8D2gMJWChrRWRdicjacyk4pcK7DsJszxIK0UGpf i4gId0Er1zx9YjVI9ZZ4qqohz7aJw4sk+P4GydBzBYppaPxKUwaKN71286OLDlgm ygYNtkI7z79uxRD9Ug+ACKDcL4deEpVkmm2h44jPcWVnYZn6C4vdiVcXYOcpC0u5 YkxCFtL3Glcpo2psxEVhO8MGfMHL44usq8256oeUH23L0SqIpKDdBy9hdPFxR+h/ 0/gHzWoCGOP2q2NHtWTT1l36X7KAGg== =zy6B -----END PGP SIGNATURE----- --=-=-=--