From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Mon, 7 Jun 2021 10:27:42 +1000 Message-ID: <312D53B8-0B55-40BD-8652-39848045E639@bydasein.com> References: <4cf0b73bcefc7d159881d368b3a4b7f5@purelymail.com> <228099F1-BAB6-4E3A-AD0F-FB4282817CEB@bydasein.com> <83mts3ikoa.fsf@gnu.org> <2C0F466D-0FEB-439B-8049-D8EA5FC0B21B@bydasein.com> <8CCF969D-32AF-4542-8838-21DF4AA45523@yasufuku.dev> <9814156B-6B84-4CFA-9F5F-A1B05F19826F@bydasein.com> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14736"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 07 03:38:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lq4EE-0003aP-0I for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Jun 2021 03:38:58 +0200 Original-Received: from [::1] (port=52210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lq3mb-0004Kb-Vs for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 21:10:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq3Aa-0000zg-Lt for emacs-devel@gnu.org; Sun, 06 Jun 2021 20:33:24 -0400 Original-Received: from [34.202.193.197] (port=46498 helo=sendmail.purelymail.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq39b-0007mc-29 for emacs-devel@gnu.org; Sun, 06 Jun 2021 20:30:43 -0400 DKIM-Signature: a=rsa-sha256; b=nUx8rZ+N7djyXyivB2/UEdBF287nNL0V/MLnwaMO/Vrm2Ts63XAW/BRVWNkw4l/5R5bsZln+lfbzjJzAUqSs4ekuCUlFd4+jOp4NeyAl0rynFXtbJ5VqqDnVXJHrKYDKC0wwiXDP6aEtzkhbO3dJSkZ0VZcqnRD5sBMN1GHPv6tUCQRQI7u4+cZN9TII7FB6P664bZgggFhSVjcXWohJHGXIyQhRvfFmBBAzgzyQ8I1coLF5O/sqVqjsYEhc0HqR04SUXPEcc1BsnCVuog4N4vB/2G5Lt5EWtZzhPbUkD1Avqp5gS7CuqLwXEzY4Q5fiC2NDMzpHQ+PpyQW0e6qSPQ==; s=purelymail3; d=bydasein.com; v=1; bh=6DXe1NUrJJdvQTKtvmhybXGNTCGKaCGmBUT8LWYu4GU=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=1sBq/iKlwu3S3udVhniEme55G+AzSRSwfiBTL/X70Y6qu0MZE/LE2ZXuBE4LJv5pF+RtzjzEhx/hTQ9yu64OP96yk5sv+OKXW2fRbXOb0vcPEyq1498jMCLz2KnwuOVadUEk+Yikoi2hQXj35a+/4Zf+1YAF0jlYVhu7KOG6vCg9Xm1ZXiCyzMTE6TNVrt4i7UNqi7TI/8WtzlTOgeMuRSVgoz5gDbfKpcdRfLAgNtHhXpz1ZtBjwW/hBxx136yd9GhmqQ+0GTLfqHotXRdz7m+SStukSIXGXkY/ZpZOxZdHVusKfzVTDhjpTYVzQrYALJ0lQJ31jU+OFJWTIaVuPg==; s=purelymail3; d=purelymail.com; v=1; bh=6DXe1NUrJJdvQTKtvmhybXGNTCGKaCGmBUT8LWYu4GU=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-164.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -1664802618; Mon, 07 Jun 2021 00:27:47 +0000 (UTC) In-Reply-To: X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Host-Lookup-Failed: Reverse DNS lookup failed for 34.202.193.197 (deferred) Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270512 Archived-At: > On 7 Jun 2021, at 4:56 am, Alan Third wrote: >=20 > On Sun, Jun 06, 2021 at 10:19:57PM +1000, Paul W. Rankin wrote: >=20 >> Alan did you see my video of this in action? >> https://f002.backblazeb2.com/file/pwr-share/emacs_nsterm.mov >=20 > Yeah, I was wrong, it is there and it's very annoying. I think there's > a mismatch between the calculation of the height of the content and > the actual height of the content. But if it's that I have no idea why > it disappears when the toolbar is turned off, because the calculation > should still be wrong. I've forgotten, what macOS version are you on? macOS 11 combines native = toolbars in with the titlebar, so I suspect that the calculations Emacs = is doing expect a separate titlebar and toolbar. >> Yeah we're considering this a separate nice-to-have, right? >=20 > Yeah, the tabs work exactly as I'd expect them to in fullscreen given > the way fullscreen works just now. >=20 > I have to say I've spent most of the afternoon on this and I'm no > closer to a solution to the height changing thing, so I'm tempted to > revert the commit, or put it behind a build flag or something until we > have a better solution. I do not think that is necessary. I'm going to go out on a limb here and = speculate that the problem lies with the way Emacs is calculating its = frame size, not with the OS window manager. The heart of it is, someone = can open up Xcode and whip up a demo app with zero code that will = function perfectly well with native tabs, it's not functionality that a = program needs to implement, so whatever it is with Emacs that is = interfering with or overriding that functionality has been added in = between.=