From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Stop frames stealing eachothers' minibuffers! Date: Sun, 15 Nov 2020 09:48:44 +0100 Message-ID: <30d9c3d1-3ca1-a127-7ac5-22c331e84fc8@gmx.at> References: <835z6b27xm.fsf@gnu.org> <20201111203716.GA19003@ACM> <83v9e8ukk4.fsf@gnu.org> <837dqnvp53.fsf@gnu.org> <20201114184858.GA8992@ACM> <20201114213738.GB8992@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25652"; mail-complaints-to="usenet@ciao.gmane.io" Cc: enometh@meer.net, monnier@iro.umontreal.ca, andreyk.mad@gmail.com, emacs-devel@gnu.org To: Alan Mackenzie , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 15 09:52:54 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keDmI-0006XQ-3R for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Nov 2020 09:52:54 +0100 Original-Received: from localhost ([::1]:37146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keDmG-0000Kx-UI for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Nov 2020 03:52:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keDiY-0007Kz-6d for emacs-devel@gnu.org; Sun, 15 Nov 2020 03:49:02 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:54423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keDiV-0008JR-GT; Sun, 15 Nov 2020 03:49:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1605430126; bh=fQAGBrAZrcZYKg5d98Pxh4qbSg9M9YURyuc3vWq0Vmw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=iWnFrOgBAHC8b0nM/12QYHtJMY7ogL61EufEokfBB+d+C2KNMZ+aRBJSPCNs/chcu 9PNLFydHOVWOAq1+ajRN1uJnvJEYl7+odj20wrzpwlm7apYHCQ4dZTLB9UYXcOC7mr QuvT2a3WOqqts7UH+n5QadRKtT/FUqQZS4VLUldw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([46.125.249.96]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M2wL0-1khW1y0Me4-003NKD; Sun, 15 Nov 2020 09:48:46 +0100 In-Reply-To: <20201114213738.GB8992@ACM> Content-Language: en-US X-Provags-ID: V03:K1:Ell4EKjbKa/zB69olqwH6+wnj1ZJOaM+ySrCNNBXZiN7j4XAXK7 MbiHQ9FqWT4RSzNrBSU8ikfNtE55wXOC3pAuWJT5ZZS5sYLNDvjtL0rG0ZhwEkoZqoaJP5w NoDO/MVYkq9knz9Fg6EEbTpGabb+Yk18HFdbmkxEkx74hUFgaOuo+RUskX0loMQTyuBaXCO BWoL5qrfg1pX55QwC2ppA== X-UI-Out-Filterresults: notjunk:1;V03:K0:q642fwHUQGI=:IUMcC5w4I1NFJ0N5eEU52q F8UTvc+sB6E0TwRl6Gi5kRZ07KfPBC20HmrxEk2viy2qLk4Az0fJXOCAdnxakOcrvLYThJzDh m6+uADPLgyiuYa5KjcSF8OoeAvGibyVtGh59reVqj/KaQYjsvJ57i72xLvtQNl0M58kZ8DouM 4PtmdbN1ZCkwvigwNiRa3ALEXeeSQnx7J0+PjvdWTlNcxomJfQIwsv1DBIWcZSsynWCrGbXxI +vwoO3dNPwUyKjZE8J9ppK4EEBXmmgjzpubpuK9k4h5LFBidVrhGUsYRR5/A3m3/SZnbP45Ob 7zz2sCgDEc51RuHHKonY7zHV/c8gO53QcebSqpgUBY+lFV4vNayBetrridMlcq6G8cwZtJVPb XdLSUrqPaGwrBtvi/PvOkk5q7MlXmg0gkrn3fVyxISxoeX3zyZlMuVhbBgJGfSWKz7VjCB9+w y693O4ZP/XFCptTtxtiouX6rz/7Cgvi7zKtfO2eDQYApBRDbrWR3bJtdzAsANcjq0g/nQDsjI xq3dJktq0um6GxUMkCZ2AsdYC8kCSHW/HcpDnJMoMDlyjv4LevWwK087KfeTtJ3T3nMcMEiMW K+vAQSBQ14D7uFG/OiC8SVCkB6LjFwThTtYrQg3s4bPSf/SQiSABlzVA9HDmMWwhYFS/+2syD qOy6kF/p1JGrZ478N1Feuo9b9QZwVsLPX0uXRaqWjFDAmvnDyIGA2JgUCoqAqLTpDGyw8TWWH +L/Qaj/sWMb1pYloKMoWEuk8JayO64AmQrt9cwXm76WUVvawbTfAnMOFaBIHZCV8eSPsuvOY Received-SPF: pass client-ip=212.227.15.18; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 03:48:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259193 Archived-At: > The patch seems to fix the bug (the one about a "recursive" C-x b > displaying its error message in the wrong frame). > > Comments are welcome. IIRC restoring the window configuration here is a bad idea because any change of the window configuration you do in a nested invocation is immediately undone when the outer invocation gets in control again. So 'read_minibuf' is just as poor as 'set-window-configuration' and you can't harm either of them much by doing such changes. Both should be rewritten from scratch with a clear concept of what they are supposed to accomplish in mind. And obviously all those select_window/Fselect_window calls outside the scope of 'select-window' proper must get removed. We hardly can get them right within window.c itself so what do we expect from the others? martin