From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Mon, 30 Jan 2023 17:44:15 +0100 Message-ID: <30c3d810-ed96-a9bd-c622-1761a138515c@gmx.at> References: <834jsccepb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16372"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org To: Tom Gillespie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 30 17:45:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMXHA-00046v-2f for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Jan 2023 17:45:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMXGZ-0004wy-4A; Mon, 30 Jan 2023 11:44:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMXGX-0004wd-3V for emacs-devel@gnu.org; Mon, 30 Jan 2023 11:44:21 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMXGV-0005Bh-Hx; Mon, 30 Jan 2023 11:44:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1675097057; bh=lccGm5VRFXZFiSlokSYUPtzztGtF5YYgmToqn1XdPIY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=rdH4xWzbKU1rwro5HithbhHvxlr4HPScBluXfiLwXWa/5y1E+wULwIx9vQzn+Qk7i /ygpodS39hcfM3FJIIQwqdT00RA3ijPJbKFTZ9n5rf/I5oBrINNm+94/6qmy0b3Lbo lXOLPbym1G3H9q2CZxTAqj4tyjjcCJtRvXo+c7u4T9ELmq1q5jHm0D5Y4qT/2SsZVX j9kLBHihOlFQA5QgI8wHrW7B9qccpdDHnMjKt7PUPpEfFVelpsuuq+nYCB90VeXiBM qCDgWUgVz9TqxUldaGteElmI2WQZc5+hQYErdbesPIw7xSDqjo3yvb31OLbW4qK8nt vFencSpEENrkQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.1.100] ([213.142.96.157]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1My36T-1oROqV3lDL-00zTU4; Mon, 30 Jan 2023 17:44:17 +0100 Content-Language: en-US In-Reply-To: X-Provags-ID: V03:K1:9IIAh578VLGe1dn0uSrJSEKV9JnGBhMlXtWBDboo1+LRgzzKfmc VWPAetfMhFpD5M2XrMSMtvTJr05ZRJwOIDZL+qdB3ONSpyl8GeVuVZz+N7KAyckmgpQwI54 mYmQ8eKKwVefhmzGFKIo6jAX8EGKc6IusUMth/95L0pSkdqi4cuiZbsGgPIodslNI3y+VV2 xxKguSStKnZeur8g3x1HA== UI-OutboundReport: notjunk:1;M01:P0:SrsSFLChoaQ=;YMAIRi8bQBovsb5p116MzLfdW5L baMTY9xADxcJyFGj9lmI8B9M1nEk5BMNO/g0YvzBSl0Z+Ls3fY8c/RsqSJ/CrL7jelMw3dI9b Y4hYuumaewoJzdFQO0cF1Dba3qbdbNPeIIP2X0GnplrpiGSvICiCj87CMAYJpKcU/IHXFyNUb 15sN0yd8Fh5zDGkg+xSTC6Cdv5GgHK/cwu8i4gEAi3L9sLyhtuKM8irLSd0Jd+eZnytrlRQV7 iWhrH/JPHmiAXDiT6/bfKhFdgkcKHg+hVkvZSuC/4MeDS1DHVbZbYFCtCEV0bw1lqR7hHrz7W vjI022FXIcMY4MYx7qAhRVafYIq/R8PnRVOFQxgkwtIU5zT18l5NqcxWGAbgLg29H1LddD9ps hIgUKwkwgaKns0fijbzsGXlgiGqq13GrYNL8zckH3X6bymw/4MA7W6Ot8Q0tFaWEFA+ntqlBS aY27ewhZ5ZB+IOjfpCqHG9hKRfnqo/tNLazWiK5FsfFZHX6jHGU8lM9R65MzkYTcOd1SztPx3 obS4lOiHeiKis8O4xfduv3QWpwrkGysWXUGyxo3AogfGmilgn8OOcZkcreM8gPs5mdp6CL7iA HrmhmEDGkS1pHp9/EQWWuv251MuJsgqas0P0h/ypMMqckvrXdbVLdi7ybEbjuVZUEMBIGan/9 vR7Tiiug2UkXwcHTg8k714yR81vdEzI/GjJtJjSqNuIKOH01TiEiY50cZDmXiPWBUMhdlMXBQ aFpu9djPvqiKpl34ajlZNNpP5El9ZxO06DR2DEUGnrxASw5f4Vy8xXteBB1+ZaxuttT9mXom Received-SPF: pass client-ip=212.227.15.19; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302795 Archived-At: This + (let* ((reusable-frames (cdr (assq 'reusable-frames alist))) + (frame (or (window--frame-usable-p (selected-frame)) + (window--frame-usable-p (last-nonminibuffer-frame)))) + (window (or (get-lru-window (or reusable-frames frame) nil t)))) is probably not what you really want. AFAICT you want to reuse a window on a frame specified by 'reusable-frames' - that is a window that already shows BUFFER. But 'get-lru-window' only gives you the least recently used window of such a frame. What speaks against (defun display-buffer-use-least-recent-window (buffer alist) "..." (let* ((alist (cons (cons 'inhibit-same-window t) alist)) (window (or (display-buffer-reuse-window buffer alist) (display-buffer-use-some-window buffer alist) (display-buffer-pop-up-window buffer alist)))) (when window (window-bump-use-time window) window))) or something the like? martin