From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master 50020d026c: Untabify rcirc.el Date: Wed, 7 Sep 2022 09:42:54 -0700 Message-ID: <30b17b67-07c8-4cd6-8b03-78a46c08906c@gmail.com> References: <166254232836.24759.17163698181249816742@vcs2.savannah.gnu.org> <20220907091848.B4E13C04F04@vcs2.savannah.gnu.org> <87h71ja0ne.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28872"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 18:45:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVyBY-0007HH-O3 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 18:45:56 +0200 Original-Received: from localhost ([::1]:59854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVyBX-0004uD-8f for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 12:45:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVy8h-0003Mw-71 for emacs-devel@gnu.org; Wed, 07 Sep 2022 12:43:02 -0400 Original-Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:45797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVy8f-0003q2-74 for emacs-devel@gnu.org; Wed, 07 Sep 2022 12:42:58 -0400 Original-Received: by mail-pj1-x1033.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso10471507pjd.4 for ; Wed, 07 Sep 2022 09:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc:subject :date; bh=6qVx4xDb2z73nozh2L1ff71Exdq47/X2xS7R+JDjUpE=; b=LJr/DHZo4gJqak0dFVBzLMtL87hCmBzH7pHAzE2qLWNpcat+B/xNl9hqbQ37Ff64eN gTmPMl+x5IJzd0WuJeozovxwVFd1QYwjMONMlrrQReIRyCKcvShOr9FtaBGSGVwhWAjA cjWDNFr3AccnT5JbyqmudVDWJk7D+w92IxqtnDq2xgcrWafI9Bie0G1wa6/P33x8YZ/u PrcNYDJp/WeMuUkPLZcxu6Z9r/9+WFXFReEGxG71rTGHXUbSm3HboKiLt/qQyytT80RW Las1yRElZi//uqCPy/x01wGqmj1u8aRFSqK2DQ9INUcF0ifeq4DGyipaLMaUmzZt3wjc DXTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc:subject:date; bh=6qVx4xDb2z73nozh2L1ff71Exdq47/X2xS7R+JDjUpE=; b=3bzON+DMtZ711+6E/Hp2wOQcXzc6ktGaNqOrv3awG4E6y8GyN7gkXcPZ5J1hvr68F1 FNumWpW6QVNT8fOrbrpePyDDBQRUW/0c16WW4lYk6BQQDQ9sCW6BLhY/xvMsh7zJeHKG e+qNPd3m2aNRyVGKKY7YFC8JYATC8nv4LVp8K0Bp2E8SUKu8wtcujDBT0yC21bCWWgTy g38Ia+wn6/varC5Tu+29VJOCxPWMLGU+Ck2Ab1Iq/zxMiaSkW1EXZ7XpU7I45r1Ukgcd QKTk5nr2D7ZUo0hV8vLAGk2taK8t/nPPBvXsm1x8MZLJ2uzUX1osH/9FeytyqZQkFvxm 4dPQ== X-Gm-Message-State: ACgBeo0/vVpAtWBQsxDliYe3IJxisDBHdPMjku6dK2xhgcJQnADxNmPK LsDpITehu9pDQoyGOW6EBW4= X-Google-Smtp-Source: AA6agR6pX+B73rBcyXmmqiVEuKzEwThZdbxErEakBBwsbCjy8eycGM09bn5vq2ETirRR9GhQEEeIUw== X-Received: by 2002:a17:903:2411:b0:172:ba7e:e54d with SMTP id e17-20020a170903241100b00172ba7ee54dmr4517133plo.165.1662568974798; Wed, 07 Sep 2022 09:42:54 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b14-20020a1709027e0e00b0016be596c8afsm12522215plm.282.2022.09.07.09.42.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Sep 2022 09:42:53 -0700 (PDT) In-Reply-To: <87h71ja0ne.fsf@yahoo.com> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294852 Archived-At: On 9/7/2022 4:23 AM, Po Lu wrote: > Philip Kaludercic writes: > >> branch: master >> commit 50020d026cda1fdd70d8a08e08185dbb7183646a >> Author: Philip Kaludercic >> Commit: Philip Kaludercic >> >> Untabify rcirc.el > > (There's nothing wrong with tabs, not in Lisp code, not elsewhere. But > that's besides the point.) > > Please don't make whitespace changes like this. It makes vc-annotate > nonfunctional and is very much unnecessary. Perhaps we should set 'blame.ignoreRevsFile'[1] in the Emacs repo's Git config (and then add this commit SHA to that file)? That should make vc-annotate - and anything else that uses "git blame" - ignore this commit, along with any other mechanical commits that shouldn't count for the purposes of blame. I believe this was introduced in Git 2.23 (from Aug 2019), so most people with relatively-recent Git installs should be able to use this. I'm not sure how robust this feature is (i.e. can it properly ignore complex changes?), but for changing tabs to spaces, that should be pretty trivial for Git to figure out. [1] https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt